Re: [PATCH v2 1/6] x86/mm/pat: Change PAT to support non-default PAT MSR

From	Thomas Gleixner <tglx@linutronix.de>
Newsgroups	linux.kernel
Subject	Re: [PATCH v2 1/6] x86/mm/pat: Change PAT to support non-default PAT MSR
Date	2016-03-22 20:30 +0100
Message-ID	<rfAa6-GO-5@gated-at.bofh.it> (permalink)
References	<rdtw7-7MK-23@gated-at.bofh.it> <rdtw7-7MK-21@gated-at.bofh.it> <rfxOW-7kp-1@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Tue, 22 Mar 2016, Borislav Petkov wrote:
> > +static void pat_keep_handoff_state(void)
> 
> Static function, no need for "pat_" prefix. Also, no need for the
> kernel-doc comment.

I have to disagree. kernel-doc comments are not limited to global
functions.

I realy prefer kernel-doc style for static functions over randomly formatted
ones for consistency reasons.

Thanks,

	tglx

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

Re: [PATCH v2 1/6] x86/mm/pat: Change PAT to support non-default PAT  MSR Borislav Petkov <bp@suse.de> - 2016-03-22 18:00 +0100
  Re: [PATCH v2 1/6] x86/mm/pat: Change PAT to support non-default  PAT MSR Toshi Kani <toshi.kani@hpe.com> - 2016-03-22 19:30 +0100
    Re: [PATCH v2 1/6] x86/mm/pat: Change PAT to support non-default PAT  MSR Borislav Petkov <bp@suse.de> - 2016-03-23 09:50 +0100
      Re: [PATCH v2 1/6] x86/mm/pat: Change PAT to support non-default  PAT MSR Toshi Kani <toshi.kani@hpe.com> - 2016-03-23 16:00 +0100
  Re: [PATCH v2 1/6] x86/mm/pat: Change PAT to support non-default  PAT MSR Thomas Gleixner <tglx@linutronix.de> - 2016-03-22 20:30 +0100

csiph-web