[PATCH] drivers/media/rc: postpone kfree(rc_dev)

From	Max Kellermann <max@duempel.org>
Newsgroups	linux.kernel
Subject	[PATCH] drivers/media/rc: postpone kfree(rc_dev)
Date	2016-03-21 13:30 +0100
Message-ID	<rf785-5yn-9@gated-at.bofh.it> (permalink)
Organization	linux.* mail to news gateway

Show all headers | View raw

CONFIG_DEBUG_KOBJECT_RELEASE found this bug.

Signed-off-by: Max Kellermann <max@duempel.org>
---
 drivers/media/rc/rc-main.c |    7 ++++++-
 1 file changed, 6 insertions(+), 1 deletion(-)

diff --git a/drivers/media/rc/rc-main.c b/drivers/media/rc/rc-main.c
index 1042fa3..cb3e8db 100644
--- a/drivers/media/rc/rc-main.c
+++ b/drivers/media/rc/rc-main.c
@@ -1248,6 +1248,9 @@ unlock:
 
 static void rc_dev_release(struct device *device)
 {
+	struct rc_dev *dev = to_rc_dev(device);
+
+	kfree(dev);
 }
 
 #define ADD_HOTPLUG_VAR(fmt, val...)					\
@@ -1369,7 +1372,9 @@ void rc_free_device(struct rc_dev *dev)
 
 	put_device(&dev->dev);
 
-	kfree(dev);
+	/* kfree(dev) will be called by the callback function
+	   rc_dev_release() */
+
 	module_put(THIS_MODULE);
 }
 EXPORT_SYMBOL_GPL(rc_free_device);

Back to linux.kernel | Previous | Next | Find similar | Unroll thread

Thread

[PATCH] drivers/media/rc: postpone kfree(rc_dev) Max Kellermann <max@duempel.org> - 2016-03-21 13:30 +0100

csiph-web