Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1360052

[PATCH] qeth: Default to allow promiscuous mode

Show all headers | View raw

When a qeth device is in bridge role, one of the ports of an adapter can
ask for promiscuous mode and get it enabled.

The default until now was to not allow user space to enable promiscuous mode
without switching sysfs attributes as well though, diverging from usual
network device semantics.

This patch sets the default to allow promiscuous enablement. That way all
existing tools "just work", albeit only one port of an adapter can be in
promiscuous mode at a given time.

Signed-off-by: Alexander Graf <agraf@suse.de>
---
 drivers/s390/net/qeth_l2_sys.c | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/drivers/s390/net/qeth_l2_sys.c b/drivers/s390/net/qeth_l2_sys.c
index 692db49..98c7ac5 100644
--- a/drivers/s390/net/qeth_l2_sys.c
+++ b/drivers/s390/net/qeth_l2_sys.c
@@ -258,6 +258,10 @@ void qeth_l2_setup_bridgeport_attrs(struct qeth_card *card)
 		return;
 	if (!card->options.sbp.supported_funcs)
 		return;
+
+	/* Allow to set promiscuous by default */
+	card->options.sbp.reflect_promisc = 1;
+
 	if (card->options.sbp.role != QETH_SBP_ROLE_NONE) {
 		/* Conditional to avoid spurious error messages */
 		qeth_bridgeport_setrole(card, card->options.sbp.role);
-- 
1.8.5.6

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

[PATCH] qeth: Default to allow promiscuous mode Alexander Graf <agraf@suse.de> - 2016-03-17 18:10 +0100
  Re: [PATCH] qeth: Default to allow promiscuous mode "Evgeny Cherkashin" <Eugene.Crosser@ru.ibm.com> - 2016-03-17 19:00 +0100
  Re: [PATCH] qeth: Default to allow promiscuous mode Alexander Graf <agraf@suse.de> - 2016-03-18 10:40 +0100
    Re: [PATCH] qeth: Default to allow promiscuous mode "Evgeny Cherkashin" <Eugene.Crosser@ru.ibm.com> - 2016-03-18 14:10 +0100

csiph-web