Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1357044
| From | Johannes Thumshirn <jthumshirn@suse.de> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [PATCH v2 2/3] block: convert to device_add_disk() |
| Date | 2016-03-14 09:20 +0100 |
| Message-ID | <rcvTk-1bk-5@gated-at.bofh.it> (permalink) |
| References | <rbxua-8i6-17@gated-at.bofh.it> <rbxua-8i6-29@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
On Fri, Mar 11, 2016 at 07:47:38AM -0800, Dan Williams wrote: > For block drivers that specify a parent device, convert them to use > device_add_disk(). > > This conversion was done with the following semantic patch: > > @@ > struct gendisk *disk; > expression E; > @@ > > - disk->driverfs_dev = E; > ... > - add_disk(disk); > + device_add_disk(E, disk); > > @@ > struct gendisk *disk; > expression E1, E2; > @@ > > - disk->driverfs_dev = E1; > ... > E2 = disk; > ... > - add_disk(E2); > + device_add_disk(E1, E2); > > ...plus some manual fixups for a few missed conversions. > > Cc: Jens Axboe <axboe@fb.com> > Cc: Christoph Hellwig <hch@lst.de> > Cc: Keith Busch <keith.busch@intel.com> > Cc: Michael S. Tsirkin <mst@redhat.com> > Cc: Ulf Hansson <ulf.hansson@linaro.org> > Cc: David Woodhouse <dwmw2@infradead.org> > Cc: David S. Miller <davem@davemloft.net> > Cc: James Bottomley <James.Bottomley@hansenpartnership.com> > Cc: Ross Zwisler <ross.zwisler@linux.intel.com> > Cc: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com> > Cc: Martin K. Petersen <martin.petersen@oracle.com> > Signed-off-by: Dan Williams <dan.j.williams@intel.com> Reviewed-by: Johannes Thumshirn <jthumshirn@suse.de> -- Johannes Thumshirn Storage jthumshirn@suse.de +49 911 74053 689 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: Felix Imendörffer, Jane Smithard, Graham Norton HRB 21284 (AG Nürnberg) Key fingerprint = EC38 9CAB C2C4 F25D 8600 D0D0 0393 969D 2D76 0850
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
[PATCH v2 0/3] Introduce device_add_disk() to kill gendisk.driverfs_dev Dan Williams <dan.j.williams@intel.com> - 2016-03-11 16:50 +0100
[PATCH v2 3/3] block: remove ->driverfs_dev Dan Williams <dan.j.williams@intel.com> - 2016-03-11 16:50 +0100
Re: [PATCH v2 3/3] block: remove ->driverfs_dev Johannes Thumshirn <jthumshirn@suse.de> - 2016-03-14 09:20 +0100
[PATCH v2 2/3] block: convert to device_add_disk() Dan Williams <dan.j.williams@intel.com> - 2016-03-11 16:50 +0100
Re: [PATCH v2 2/3] block: convert to device_add_disk() Johannes Thumshirn <jthumshirn@suse.de> - 2016-03-14 09:20 +0100
[PATCH v2 1/3] block: introduce device_add_disk() Dan Williams <dan.j.williams@intel.com> - 2016-03-11 16:50 +0100
Re: [PATCH v2 1/3] block: introduce device_add_disk() Johannes Thumshirn <jthumshirn@suse.de> - 2016-03-14 09:20 +0100
Re: [PATCH v2 0/3] Introduce device_add_disk() to kill gendisk.driverfs_dev Christoph Hellwig <hch@infradead.org> - 2016-03-11 17:40 +0100
csiph-web