Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1356794

Re: [PATCH] x86/efi: Always map boot service regions into new EFI page tables

From Scott Ashcroft <scott.ashcroft@talk21.com>
Newsgroups linux.kernel
Subject Re: [PATCH] x86/efi: Always map boot service regions into new EFI page tables
Date 2016-03-14 02:10 +0100
Message-ID <rcpbb-51v-3@gated-at.bofh.it> (permalink)
References <rbtgS-5hR-25@gated-at.bofh.it> <rbtqy-5pl-13@gated-at.bofh.it> <rchQm-gi-17@gated-at.bofh.it> <rcmdl-2U2-7@gated-at.bofh.it> <rcnj3-3Oo-3@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw


On Sun, 2016-03-13 at 23:07 +0000, Matt Fleming wrote:
> Assuming the answer to this question is "no", can you try out this
> patch?
> 
> diff --git a/arch/x86/mm/pageattr.c b/arch/x86/mm/pageattr.c
> index 8fee5b6f8f66..af74849e8c0f 100644
> --- a/arch/x86/mm/pageattr.c
> +++ b/arch/x86/mm/pageattr.c
> @@ -1055,7 +1055,7 @@ static int populate_pud(struct cpa_data *cpa,
> unsigned long start, pgd_t *pgd,
>  	/*
>  	 * Map everything starting from the Gb boundary, possibly
> with 1G pages
>  	 */
> -	while (end - start >= PUD_SIZE) {
> +	while (cpu_has_gbpages && end - start >= PUD_SIZE) {
>  		set_pud(pud, __pud(cpa->pfn << PAGE_SHIFT |
> _PAGE_PSE |
>  				   massage_pgprot(pud_pgprot)));
> 

Yes, that does fix it.

Cheers,
Scott

Back to linux.kernel | Previous | NextPrevious in thread | Next in thread | Find similar | Unroll thread


Thread

[GIT PULL] EFI urgent fix for v4.6 queue Matt Fleming <matt@codeblueprint.co.uk> - 2016-03-11 12:20 +0100
  [PATCH] x86/efi: Always map boot service regions into new EFI page tables Matt Fleming <matt@codeblueprint.co.uk> - 2016-03-11 12:30 +0100
    [tip:x86/urgent] x86/efi: Fix boot crash by always mapping boot  service regions into new EFI page tables tip-bot for Matt Fleming <tipbot@zytor.com> - 2016-03-12 20:00 +0100
      Re: [tip:x86/urgent] x86/efi: Fix boot crash by always mapping boot  service regions into new EFI page tables Matt Fleming <matt@codeblueprint.co.uk> - 2016-03-13 00:10 +0100
        Re: [tip:x86/urgent] x86/efi: Fix boot crash by always mapping boot  service regions into new EFI page tables Ingo Molnar <mingo@kernel.org> - 2016-03-13 19:00 +0100
    Re: [PATCH] x86/efi: Always map boot service regions into new EFI  page tables Matt Fleming <matt@codeblueprint.co.uk> - 2016-03-13 23:00 +0100
      Re: [PATCH] x86/efi: Always map boot service regions into new EFI  page tables Matt Fleming <matt@codeblueprint.co.uk> - 2016-03-14 00:10 +0100
        Re: [PATCH] x86/efi: Always map boot service regions into new EFI  page tables Scott Ashcroft <scott.ashcroft@talk21.com> - 2016-03-14 02:10 +0100
        Re: [PATCH] x86/efi: Always map boot service regions into new EFI  page tables Ingo Molnar <mingo@kernel.org> - 2016-03-14 11:40 +0100
          Re: [PATCH] x86/efi: Always map boot service regions into new EFI  page tables Matt Fleming <matt@codeblueprint.co.uk> - 2016-03-14 12:40 +0100
            Re: [PATCH] x86/efi: Always map boot service regions into new EFI  page tables Ingo Molnar <mingo@kernel.org> - 2016-03-14 13:10 +0100
              Re: [PATCH] x86/efi: Always map boot service regions into new EFI  page tables Matt Fleming <matt@codeblueprint.co.uk> - 2016-03-14 15:30 +0100
                Re: [PATCH] x86/efi: Always map boot service regions into new EFI  page tables Ingo Molnar <mingo@kernel.org> - 2016-03-14 17:50 +0100
                Re: [PATCH] x86/efi: Always map boot service regions into new EFI  page tables Matt Fleming <matt@codeblueprint.co.uk> - 2016-03-15 17:00 +0100
                Re: [PATCH] x86/efi: Always map boot service regions into new EFI  page tables Borislav Petkov <bp@alien8.de> - 2016-03-15 17:10 +0100
                Re: [PATCH] x86/efi: Always map boot service regions into new EFI  page tables Julia Lawall <julia.lawall@lip6.fr> - 2016-03-15 17:30 +0100

csiph-web