Re: [PATCH net-next 2/3] net: dsa: make port_bridge_leave return void

From	Jiri Pirko <jiri@resnulli.us>
Newsgroups	linux.kernel
Subject	Re: [PATCH net-next 2/3] net: dsa: make port_bridge_leave return void
Date	2016-03-13 22:00 +0100
Message-ID	<rclhf-2kF-1@gated-at.bofh.it> (permalink)
References	<rckOd-28v-3@gated-at.bofh.it> <rckOe-28v-9@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

Sun, Mar 13, 2016 at 09:21:33PM CET, vivien.didelot@savoirfairelinux.com wrote:
>netdev_upper_dev_unlink() which notifies NETDEV_CHANGEUPPER, returns
>void, as well as del_nbp(). So there's no advantage to catch an eventual
>error from the port_bridge_leave routine at the DSA level.
>
>Make this routine void for the DSA layer and its existing drivers.
>
>Signed-off-by: Vivien Didelot <vivien.didelot@savoirfairelinux.com>

Acked-by: Jiri Pirko <jiri@mellanox.com>

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH net-next 2/3] net: dsa: make port_bridge_leave return void Vivien Didelot <vivien.didelot@savoirfairelinux.com> - 2016-03-13 21:30 +0100
  Re: [PATCH net-next 2/3] net: dsa: make port_bridge_leave return void Jiri Pirko <jiri@resnulli.us> - 2016-03-13 22:00 +0100

csiph-web