Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1357678

Re: [PATCH v2] rtc: s3c: Don't print an error on probe deferral

Show all headers | View raw

On 14/03/2016 at 18:07:36 -0300, Javier Martinez Canillas wrote :
> Hello Joe,
> 
> On 03/14/2016 05:30 PM, Joe Perches wrote:
> > On Mon, 2016-03-14 at 17:25 -0300, Javier Martinez Canillas wrote:
> >> The clock and source clock looked up by the driver may not be available
> >> just because the clock controller driver was not probed yet so printing
> >> an error in this case is not correct and only adds confusion to users.
> >>
> >> However, knowing that a driver's probe was deferred may be useful so it
> >> can be printed as debug information.
> > 
> > Hello again Javier:
> >> +			dev_dbg(&pdev->dev, "probe deferred due missing rtc clk\n");
> > 
> > Again, intelligible English would not use "due"
> > but would use "due to" or "because of".
> > 
> 
> Ok, I'll post another version then. I hope the third time's the charm...
> 
> Alexandre, do you have any other comments before I re-spin this patch?
> 

No further comments :)


-- 
Alexandre Belloni, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH v2] rtc: s3c: Don't print an error on probe deferral Javier Martinez Canillas <javier@osg.samsung.com> - 2016-03-14 21:30 +0100
  Re: [PATCH v2] rtc: s3c: Don't print an error on probe deferral Joe Perches <joe@perches.com> - 2016-03-14 21:40 +0100
    Re: [PATCH v2] rtc: s3c: Don't print an error on probe deferral Javier Martinez Canillas <javier@osg.samsung.com> - 2016-03-14 22:10 +0100
      Re: [PATCH v2] rtc: s3c: Don't print an error on probe deferral Alexandre Belloni <alexandre.belloni@free-electrons.com> - 2016-03-15 00:00 +0100

csiph-web