Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1356176

Re: [PATCH] epoll: add exclusive wakeups flag

From "Michael Kerrisk (man-pages)" <mtk.manpages@gmail.com>
Newsgroups linux.kernel
Subject Re: [PATCH] epoll: add exclusive wakeups flag
Date 2016-03-11 21:40 +0100
Message-ID <rbC0N-3ei-1@gated-at.bofh.it> (permalink)
References (2 earlier) <qVZ1o-6V6-9@gated-at.bofh.it> <qWcrE-8oa-13@gated-at.bofh.it> <rbdYu-2Ao-13@gated-at.bofh.it> <rbeUy-3aN-1@gated-at.bofh.it> <rbfGW-3KY-1@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw

>> By the way, in the code you have
>>
>>         case EPOLL_CTL_MOD:
>>                 if (epi) {
>>                         if (!(epi->event.events & EPOLLEXCLUSIVE)) {
>>                                 epds.events |= POLLERR | POLLHUP;
>>                                 error = ep_modify(ep, epi, &epds);
>>                         }
>>
>> I think the "if" here is redundant. IIUC, earlier in the code you
>> disallow EPOLL_CTL_MOD with EPOLLEXCLUSIVE.
>>
>> Cheers,
>>
>> Michael
>>
>>
>
> Hi Michael,
>
> So the previous check ensures that you can not add the EPOLLEXCLUSIVE
> flag to the events via an EPOLL_CTL_MOD operation, where EPOLLEXCLUSIVE
> may not be the existing events set. While this check here ensure you
> can't modify an existing set that already has the EPOLLEXCLUSIVE flag.

Hmmm - I misread the code, itr seems :-/. Could you please carefully
check the man page text I sent earlier in this thread. Maybe I
injected some errors into the text.

Thanks,

Michael

-- 
Michael Kerrisk
Linux man-pages maintainer; http://www.kernel.org/doc/man-pages/
Linux/UNIX System Programming Training: http://man7.org/training/

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

Re: [PATCH] epoll: add exclusive wakeups flag Jason Baron <jbaron@akamai.com> - 2016-03-10 20:00 +0100
  Re: [PATCH] epoll: add exclusive wakeups flag "Michael Kerrisk (man-pages)" <mtk.manpages@gmail.com> - 2016-03-10 20:50 +0100
  Re: [PATCH] epoll: add exclusive wakeups flag "Michael Kerrisk (man-pages)" <mtk.manpages@gmail.com> - 2016-03-10 21:00 +0100
    Re: [PATCH] epoll: add exclusive wakeups flag Jason Baron <jbaron@akamai.com> - 2016-03-10 21:50 +0100
      Re: [PATCH] epoll: add exclusive wakeups flag "Michael Kerrisk (man-pages)" <mtk.manpages@gmail.com> - 2016-03-11 21:40 +0100
        Re: [PATCH] epoll: add exclusive wakeups flag "Michael Kerrisk (man-pages)" <mtk.manpages@gmail.com> - 2016-03-14 18:50 +0100
          Re: [PATCH] epoll: add exclusive wakeups flag Jason Baron <jbaron@akamai.com> - 2016-03-14 20:40 +0100
            Re: [PATCH] epoll: add exclusive wakeups flag "Michael Kerrisk (man-pages)" <mtk.manpages@gmail.com> - 2016-03-14 21:10 +0100
              Re: [PATCH] epoll: add exclusive wakeups flag "Michael Kerrisk (man-pages)" <mtk.manpages@gmail.com> - 2016-03-14 22:10 +0100
                Re: [PATCH] epoll: add exclusive wakeups flag Jason Baron <jbaron@akamai.com> - 2016-03-14 23:40 +0100
                Re: [PATCH] epoll: add exclusive wakeups flag Madars Vitolins <m@silodev.com> - 2016-03-15 00:30 +0100
                Re: [PATCH] epoll: add exclusive wakeups flag "Michael Kerrisk (man-pages)" <mtk.manpages@gmail.com> - 2016-03-15 00:30 +0100
                Re: [PATCH] epoll: add exclusive wakeups flag Jason Baron <jbaron@akamai.com> - 2016-03-15 03:50 +0100

csiph-web