Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1356148
| From | Sergei Shtylyov <sergei.shtylyov@cogentembedded.com> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [PATCH 3/6] net: arc_emac: support the phy reset for emac driver |
| Date | 2016-03-11 20:30 +0100 |
| Message-ID | <rbAV4-2r7-9@gated-at.bofh.it> (permalink) |
| References | <rbsXv-4QJ-3@gated-at.bofh.it> <rbt7c-5b2-21@gated-at.bofh.it> |
| Organization | Cogent Embedded |
On 03/11/2016 01:55 PM, Caesar Wang wrote:
> This patch adds to support the emac phy reset.
>
> 1) phy-reset-gpios:
> The phy-reset-gpios is an optional property for arc emac device tree boot.
> Change the binding document to match the driver code.
>
> 2) phy-reset-duration:
> Different boards may require different phy reset duration. Add property
> phy-reset-duration for device tree probe, so that the boards that need
> a longer reset duration can specify it in their device tree.
>
> 3) phy-reset-active-high:
> We need that for a custom hardware that needs the reverse reset sequence.
What concerns me the most about the existing (and suggested) PHY reset
related props is that they are located in the MAC device node while not having
*anything* to do with the MAC at all! These props actually belong to the PHY
nodes, and I'm currently looking into how to handle them there, where they
belong...
> Of course, this patch will fix the issue on
> https://patchwork.kernel.org/patch/8186801/.
>
> In some cases, the emac couldn't work if you don't have reset the phy.
> Let's add it to happy work.
>
> Signed-off-by: Caesar Wang <wxt@rock-chips.com>
[...]
MBR, Sergei
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
[PATCH 0/6] arc_emac: fixes the emac issues oand cleanup emac drivers Caesar Wang <wxt@rock-chips.com> - 2016-03-11 12:00 +0100
[PATCH 2/6] net: arc_emac: add phy-reset-* are optional for device tree Caesar Wang <wxt@rock-chips.com> - 2016-03-11 12:00 +0100
[PATCH 3/6] net: arc_emac: support the phy reset for emac driver Caesar Wang <wxt@rock-chips.com> - 2016-03-11 12:10 +0100
Re: [PATCH 3/6] net: arc_emac: support the phy reset for emac driver Sergei Shtylyov <sergei.shtylyov@cogentembedded.com> - 2016-03-11 14:50 +0100
Re: [PATCH 3/6] net: arc_emac: support the phy reset for emac driver Heiko Stübner <heiko@sntech.de> - 2016-03-11 16:00 +0100
Re: [PATCH 3/6] net: arc_emac: support the phy reset for emac driver Heiko Stübner <heiko@sntech.de> - 2016-03-11 16:00 +0100
Re: [PATCH 3/6] net: arc_emac: support the phy reset for emac driver Sergei Shtylyov <sergei.shtylyov@cogentembedded.com> - 2016-03-11 19:40 +0100
Re: [PATCH 3/6] net: arc_emac: support the phy reset for emac driver Caesar Wang <caesar.upstream@gmail.com> - 2016-03-13 05:00 +0100
Re: [PATCH 3/6] net: arc_emac: support the phy reset for emac driver Sergei Shtylyov <sergei.shtylyov@cogentembedded.com> - 2016-03-11 20:30 +0100
Re: [PATCH 0/6] arc_emac: fixes the emac issues oand cleanup emac drivers Sergei Shtylyov <sergei.shtylyov@cogentembedded.com> - 2016-03-11 14:50 +0100
Re: [PATCH 0/6] arc_emac: fixes the emac issues oand cleanup emac drivers Caesar Wang <caesar.upstream@gmail.com> - 2016-03-11 15:50 +0100
Re: [PATCH 0/6] arc_emac: fixes the emac issues oand cleanup emac drivers Sergei Shtylyov <sergei.shtylyov@cogentembedded.com> - 2016-03-11 19:50 +0100
Re: [PATCH 0/6] arc_emac: fixes the emac issues oand cleanup emac drivers Caesar Wang <caesar.upstream@gmail.com> - 2016-03-13 05:10 +0100
csiph-web