Re: [RFC PATCH 2/2] KVM: MMU: return page fault error code from permission_fault

From	Paolo Bonzini <pbonzini@redhat.com>
Newsgroups	linux.kernel
Subject	Re: [RFC PATCH 2/2] KVM: MMU: return page fault error code from permission_fault
Date	2016-03-10 15:10 +0100
Message-ID	<rb9rR-823-35@gated-at.bofh.it> (permalink)
References	<raojh-hv-37@gated-at.bofh.it> <raojh-hv-43@gated-at.bofh.it> <rb9rR-823-31@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw


On 10/03/2016 15:03, Xiao Guangrong wrote:
> 
> 
> On 03/08/2016 07:45 PM, Paolo Bonzini wrote:
>> Intel's new PKU extension introduces a bit of the page fault error code
>> that must be dynamically computed after the PTE lookup (unlike I/D, U/S
>> and W/R).  To ease this, these two patches make permission_fault return
>> the page fault error code.
>>
>> Right now it only adds the P bit to the input parameter "pfec", but PKU
>> can change that.
> 
> Yep, i got the same idea when i reviewed the pkey patchset. This patch
> looks good to me.
> 
> Reviewed-by: Xiao Guangrong <guangrong.xiao@linux.intel.com>

Great, feel free to pick it up in the pkey patchset.  I'm answering to
1/2 now.

Paolo

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[RFC PATCH 0/2] KVM: MMU: return page fault error code from permission_fault Paolo Bonzini <pbonzini@redhat.com> - 2016-03-08 12:50 +0100
  [RFC PATCH 1/2] KVM: MMU: precompute page fault error code Paolo Bonzini <pbonzini@redhat.com> - 2016-03-08 12:50 +0100
    Re: [RFC PATCH 1/2] KVM: MMU: precompute page fault error code Paolo Bonzini <pbonzini@redhat.com> - 2016-03-10 15:10 +0100
    Re: [RFC PATCH 1/2] KVM: MMU: precompute page fault error code Xiao Guangrong <guangrong.xiao@linux.intel.com> - 2016-03-10 15:10 +0100
  [RFC PATCH 2/2] KVM: MMU: return page fault error code from permission_fault Paolo Bonzini <pbonzini@redhat.com> - 2016-03-08 12:50 +0100
    Re: [RFC PATCH 2/2] KVM: MMU: return page fault error code from  permission_fault Xiao Guangrong <guangrong.xiao@linux.intel.com> - 2016-03-10 15:10 +0100
      Re: [RFC PATCH 2/2] KVM: MMU: return page fault error code from  permission_fault Paolo Bonzini <pbonzini@redhat.com> - 2016-03-10 15:10 +0100

csiph-web