Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1354911
| From | Andy Shevchenko <andriy.shevchenko@linux.intel.com> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [patch net 1/2] net: hns: fix return value of the function about rss |
| Date | 2016-03-10 09:20 +0100 |
| Message-ID | <rb3Z8-47H-11@gated-at.bofh.it> (permalink) |
| References | <raY3p-8ft-15@gated-at.bofh.it> <raY3p-8ft-17@gated-at.bofh.it> |
| Organization | Intel Finland Oy |
On Thu, 2016-03-10 at 10:16 +0800, Kejian Yan wrote: > Both .get_rxfh and .get_rxfh are always return 0, it should return > result > from hardware when getting or setting rss. And the rss function > should > return the correct data type. > @@ -1213,7 +1213,7 @@ hns_get_rss(struct net_device *netdev, u32 > *indir, u8 *key, u8 *hfunc) > > > ret = ops->get_rss(priv->ae_handle, indir, key, hfunc); > > - return 0; > + return ret; All three can be one line. > @@ -1241,7 +1241,7 @@ hns_set_rss(struct net_device *netdev, const > u32 *indir, const u8 *key, > > ret = ops->set_rss(priv->ae_handle, indir, key, hfunc); > > - return 0; > + return ret; Ditto. -- Andy Shevchenko <andriy.shevchenko@linux.intel.com> Intel Finland Oy
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
[patch net 0/2] net: hns: get and set RSS indirection table by using ethtool Kejian Yan <yankejian@huawei.com> - 2016-03-10 03:00 +0100
[patch net 1/2] net: hns: fix return value of the function about rss Kejian Yan <yankejian@huawei.com> - 2016-03-10 03:00 +0100
Re: [patch net 1/2] net: hns: fix return value of the function about rss Andy Shevchenko <andriy.shevchenko@linux.intel.com> - 2016-03-10 09:20 +0100
Re: [patch net 1/2] net: hns: fix return value of the function about rss "Yankejian (Hackim Yim)" <yankejian@huawei.com> - 2016-03-10 13:10 +0100
csiph-web