Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1353070
| From | Leo Yan <leo.yan@linaro.org> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [PATCH v2 1/5] thermal: change "hysteresis" as optional property |
| Date | 2016-03-08 15:00 +0100 |
| Message-ID | <raql5-1Bi-37@gated-at.bofh.it> (permalink) |
| References | <r6hzH-5IV-3@gated-at.bofh.it> <r6hzI-5IV-13@gated-at.bofh.it> <r8Eiw-1kl-33@gated-at.bofh.it> <r8OhQ-ix-3@gated-at.bofh.it> <r8WyK-69A-7@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
Hi Eduardo, On Fri, Mar 04, 2016 at 11:57:53AM +0000, Javi Merino wrote: > On Fri, Mar 04, 2016 at 11:03:49AM +0800, Leo Yan wrote: > > On Thu, Mar 03, 2016 at 08:29:44AM -0800, Eduardo Valentin wrote: > > > On Fri, Feb 26, 2016 at 11:43:43AM +0800, Leo Yan wrote: [...] > > > > The property "hysteresis" is mandatory for trip points, so if without > > > > it the thermal zone cannot register successfully. But "hysteresis" is > > > > ignored in the thermal subsystem and only inquired by several thermal > > > > sensor drivers. > > > > > > If the Linux thermal subsystem has a problem with handling hysteresis, I > > > would rather fix Linux code than relaxing the DT binding. Or if you > > > still believe hysteresis is really optional, I would prefer to see a > > > better justification than "Linux ignores it". > > I see it the other way round, Is hysteresis a property that, without > it, the thermal code can't configure itself so it fails to create the > trip point? The current code goes "There is no hysteresis for this > property, I don't know how to set up this trip point!". I think we > can do better than this. Do you agree with Javi's suggestion? If you think it's okay, I will move on to send out a new version patch based on Javi's comments. Thanks, Leo Yan
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
Re: [PATCH v2 1/5] thermal: change "hysteresis" as optional property Javi Merino <javi.merino@arm.com> - 2016-03-04 13:00 +0100
Re: [PATCH v2 1/5] thermal: change "hysteresis" as optional property Leo Yan <leo.yan@linaro.org> - 2016-03-08 15:00 +0100
Re: [PATCH v2 1/5] thermal: change "hysteresis" as optional property Eduardo Valentin <edubezval@gmail.com> - 2016-03-08 22:00 +0100
Re: [PATCH v2 1/5] thermal: change "hysteresis" as optional property Javi Merino <javi.merino@arm.com> - 2016-03-09 12:20 +0100
csiph-web