Re: [PATCH v10 1/3] cpufreq: Add mechanism for registering utilization update callbacks

From	Ingo Molnar <mingo@kernel.org>
Newsgroups	linux.kernel
Subject	Re: [PATCH v10 1/3] cpufreq: Add mechanism for registering utilization update callbacks
Date	2016-03-09 14:40 +0100
Message-ID	<raMvg-5O-9@gated-at.bofh.it> (permalink)
References	<qWqbf-1BM-3@gated-at.bofh.it> <r13e2-3rD-3@gated-at.bofh.it> <r1lNE-7uT-13@gated-at.bofh.it> <r2zbQ-6MM-1@gated-at.bofh.it> <raLzb-7UF-3@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

* Peter Zijlstra <peterz@infradead.org> wrote:

> On Mon, Feb 15, 2016 at 10:47:22PM +0100, Rafael J. Wysocki wrote:
> > From: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
> > 
> > Introduce a mechanism by which parts of the cpufreq subsystem
> > ("setpolicy" drivers or the core) can register callbacks to be
> > executed from cpufreq_update_util() which is invoked by the
> > scheduler's update_load_avg() on CPU utilization changes.
> > 
> > This allows the "setpolicy" drivers to dispense with their timers
> > and do all of the computations they need and frequency/voltage
> > adjustments in the update_load_avg() code path, among other things.
> > 
> > The update_load_avg() changes were suggested by Peter Zijlstra.
> > 
> > Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
> > Acked-by: Viresh Kumar <viresh.kumar@linaro.org>
> > ---
> >  drivers/cpufreq/cpufreq.c |   45 +++++++++++++++++++++++++++++++++++++++++++++
> >  include/linux/cpufreq.h   |   34 ++++++++++++++++++++++++++++++++++
> >  kernel/sched/deadline.c   |    4 ++++
> >  kernel/sched/fair.c       |   26 +++++++++++++++++++++++++-
> >  kernel/sched/rt.c         |    4 ++++
> >  kernel/sched/sched.h      |    1 +
> >  6 files changed, 113 insertions(+), 1 deletion(-)
> > 
> 
> So with the understanding that we'll work on getting rid of
> cpufreq_trigger_update().
> 
> Acked-by: Peter Zijlstra (Intel) <peterz@infradead.org>

I'm happy with the latest iteration and with the general direction as well!

Acked-by: Ingo Molnar <mingo@kernel.org>

Thanks,

	Ingo

Thread

Re: [PATCH v10 1/3] cpufreq: Add mechanism for registering  utilization update callbacks Peter Zijlstra <peterz@infradead.org> - 2016-03-09 13:40 +0100
  Re: [PATCH v10 1/3] cpufreq: Add mechanism for registering  utilization update callbacks "Rafael J. Wysocki" <rafael@kernel.org> - 2016-03-09 14:30 +0100
  Re: [PATCH v10 1/3] cpufreq: Add mechanism for registering  utilization update callbacks "Rafael J. Wysocki" <rafael@kernel.org> - 2016-03-09 14:40 +0100
  Re: [PATCH v10 1/3] cpufreq: Add mechanism for registering  utilization update callbacks Ingo Molnar <mingo@kernel.org> - 2016-03-09 14:40 +0100
  Re: [PATCH v10 1/3] cpufreq: Add mechanism for registering  utilization update callbacks Vincent Guittot <vincent.guittot@linaro.org> - 2016-03-10 03:20 +0100

csiph-web