Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1449023
| From | Al Viro <viro@ZenIV.linux.org.uk> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [PATCH 3/7] nfsd: remove redundant i_lookup check |
| Date | 2016-07-24 02:30 +0200 |
| Message-ID | <rYfsR-Wz-3@gated-at.bofh.it> (permalink) |
| References | <rXMKd-r1-3@gated-at.bofh.it> <rXMKd-r1-1@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
On Fri, Jul 22, 2016 at 01:48:52PM -0400, J. Bruce Fields wrote: > From: "J. Bruce Fields" <bfields@redhat.com> > > I'm not sure why this was added. It doesn't seem necessary, and no > other caller does this. lookup_one_len() will explode if you call it for non-directory (== !d_can_lookup(), i.e. something without ->lookup()). So unless the callers do guarantee that check being true, it *is* needed.
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
[PATCH 3/7] nfsd: remove redundant i_lookup check "J. Bruce Fields" <bfields@redhat.com> - 2016-07-22 19:50 +0200
Re: [PATCH 3/7] nfsd: remove redundant i_lookup check Al Viro <viro@ZenIV.linux.org.uk> - 2016-07-24 02:30 +0200
Re: [PATCH 3/7] nfsd: remove redundant i_lookup check "J. Bruce Fields" <bfields@fieldses.org> - 2016-07-24 14:20 +0200
Re: [PATCH 3/7] nfsd: remove redundant i_lookup check Al Viro <viro@ZenIV.linux.org.uk> - 2016-07-24 16:30 +0200
Re: [PATCH 3/7] nfsd: remove redundant i_lookup check "J. Bruce Fields" <bfields@fieldses.org> - 2016-07-24 22:30 +0200
csiph-web