Re: [PATCH v2 02/10] userns: Add per user namespace sysctls.

From	ebiederm@xmission.com (Eric W. Biederman)
Newsgroups	linux.kernel
Subject	Re: [PATCH v2 02/10] userns: Add per user namespace sysctls.
Date	2016-07-26 02:20 +0200
Message-ID	<rYYgi-3je-15@gated-at.bofh.it> (permalink)
References	<rXpuh-1Dd-3@gated-at.bofh.it> <rXpuh-1Dd-5@gated-at.bofh.it> <rXpui-1Dd-11@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

"Eric W. Biederman" <ebiederm@xmission.com> writes:

> Limit per userns sysctls to only be opened for write by a holder
> of CAP_SYS_RESOURCE.
>
> Add all of the necessary boilerplate for having per user namespace
> sysctls.

> @@ -141,6 +215,7 @@ void free_user_ns(struct user_namespace *ns)
>  
>  	do {
>  		parent = ns->parent;
> +		retire_userns_sysctls(ns);
^^^^^^^^^^ Unfortunately it is not safe to call a sleeping function here
           so this part needs to be taken back to the drawing board.
 
           Which means this change gets has to wait for next cycle.
>  #ifdef CONFIG_PERSISTENT_KEYRINGS
>  		key_put(ns->persistent_keyring_register);
>  #endif

Eric

Thread

[PATCH v2 02/10] userns: Add per user namespace sysctls. "Eric W. Biederman" <ebiederm@xmission.com> - 2016-07-21 19:00 +0200
  Re: [PATCH v2 02/10] userns: Add per user namespace sysctls. ebiederm@xmission.com (Eric W. Biederman) - 2016-07-26 02:20 +0200
    Re: [PATCH v2 02/10] userns: Add per user namespace sysctls. David Miller <davem@davemloft.net> - 2016-07-26 02:30 +0200
      Re: [PATCH v2 02/10] userns: Add per user namespace sysctls. ebiederm@xmission.com (Eric W. Biederman) - 2016-07-26 03:00 +0200
        Re: [PATCH v2 02/10] userns: Add per user namespace sysctls. David Miller <davem@davemloft.net> - 2016-07-26 05:00 +0200
          Re: [PATCH v2 02/10] userns: Add per user namespace sysctls. ebiederm@xmission.com (Eric W. Biederman) - 2016-07-26 06:20 +0200

csiph-web