Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1448531
| From | Catalin Marinas <catalin.marinas@arm.com> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [PATCH] vfs:Fix memory leak on error path in get_empty_file |
| Date | 2016-07-22 12:50 +0200 |
| Message-ID | <rXGbL-4Fj-3@gated-at.bofh.it> (permalink) |
| References | <rXzWF-GT-3@gated-at.bofh.it> <rXzWF-GT-1@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
I can't find the original post (probably it only went to the linux-fsdevel list), so replying to Nicholas here: > On Thu, Jul 21, 2016 at 10:53:37PM -0400, Nicholas Krause wrote: >> This fixes a memory leak on the error path if the call to >> security_file_alloc fails to run successfully as detected >> in this trace by kmemleak: >> [ 321.783718] ath9k 0000:03:00.0 eth0: renamed from wlan0 >> [ 330.960024] atl1c 0000:02:00.0 eth1: renamed from eth126 >> [ 391.831384] WARNING: kmemcheck: Caught 64-bit read from uninitialized memory (ffff8800a8ad8a00) Can you please understand that kmemleak != kmemcheck, even though the names are similar? It would save both your and other developers' time. See the corresponding Kconfig help text: KMEMCHECK: "kmemcheck: trap use of uninitialized memory" DEBUG_KMEMLEAK: "Kernel memory leak detector" -- Catalin
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
Re: [PATCH] vfs:Fix memory leak on error path in get_empty_file Al Viro <viro@ZenIV.linux.org.uk> - 2016-07-22 06:10 +0200
Re: [PATCH] vfs:Fix memory leak on error path in get_empty_file Catalin Marinas <catalin.marinas@arm.com> - 2016-07-22 12:50 +0200
Re: [PATCH] vfs:Fix memory leak on error path in get_empty_file Theodore Ts'o <tytso@mit.edu> - 2016-07-23 19:10 +0200
csiph-web