[PATCH net-next] macvtap: correctly free skb during socket destruction

From	Jason Wang <jasowang@redhat.com>
Newsgroups	linux.kernel
Subject	[PATCH net-next] macvtap: correctly free skb during socket destruction
Date	2016-07-19 05:10 +0200
Message-ID	<rWtzX-6RE-3@gated-at.bofh.it> (permalink)
Organization	linux.* mail to news gateway

Show all headers | View raw

We should use kfree_skb() instead of kfree() to free an skb.

Fixes: 362899b8725b ("macvtap: switch to use skb array")
Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Jason Wang <jasowang@redhat.com>
---
 drivers/net/macvtap.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/net/macvtap.c b/drivers/net/macvtap.c
index 9204d19..a38c0da 100644
--- a/drivers/net/macvtap.c
+++ b/drivers/net/macvtap.c
@@ -536,7 +536,7 @@ static void macvtap_sock_destruct(struct sock *sk)
 	struct sk_buff *skb;
 
 	while ((skb = skb_array_consume(&q->skb_array)) != NULL)
-		kfree(skb);
+		kfree_skb(skb);
 }
 
 static int macvtap_open(struct inode *inode, struct file *file)
-- 
2.7.4

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

[PATCH net-next] macvtap: correctly free skb during socket destruction Jason Wang <jasowang@redhat.com> - 2016-07-19 05:10 +0200
  Re: [PATCH net-next] macvtap: correctly free skb during socket  destruction David Miller <davem@davemloft.net> - 2016-07-19 07:20 +0200

csiph-web