Re: [PATCH V9 4/9] vfio: platform: add support for ACPI probe

From	Sinan Kaya <okaya@codeaurora.org>
Newsgroups	linux.kernel
Subject	Re: [PATCH V9 4/9] vfio: platform: add support for ACPI probe
Date	2016-07-18 23:30 +0200
Message-ID	<rWogV-3bX-7@gated-at.bofh.it> (permalink)
References	<rUEg9-3ar-3@gated-at.bofh.it> <rUEg9-3ar-23@gated-at.bofh.it> <rUWG5-6zn-9@gated-at.bofh.it> <rVmAx-5Os-3@gated-at.bofh.it> <rWkGl-MC-1@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On 7/18/2016 1:32 PM, Alex Williamson wrote:
> The implementation looks pretty fixed, it seems like a lot would break
> if that were changed, so the callers of the function would need to be
> updated, including this one.  The ternary below is already paranoid
> enough to handle an API change, but if you want to add one more level
> of paranoia, you could use WARN_ON(!vdev->acpihid) to make it user
> visible.  It could still be done as:
> 
> return WARN_ON(!vdev->acpihid) ? -ENOENT : 0;

OK. I'm adding this and will post a new version after testing.

-- 
Sinan Kaya
Qualcomm Datacenter Technologies, Inc. as an affiliate of Qualcomm Technologies, Inc.
Qualcomm Technologies, Inc. is a member of the Code Aurora Forum, a Linux Foundation Collaborative Project.

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH V9 4/9] vfio: platform: add support for ACPI probe Sinan Kaya <okaya@codeaurora.org> - 2016-07-14 04:10 +0200
  Re: [PATCH V9 4/9] vfio: platform: add support for ACPI probe Alex Williamson <alex.williamson@redhat.com> - 2016-07-14 23:50 +0200
    Re: [PATCH V9 4/9] vfio: platform: add support for ACPI probe Sinan Kaya <okaya@codeaurora.org> - 2016-07-16 03:30 +0200
      Re: [PATCH V9 4/9] vfio: platform: add support for ACPI probe Alex Williamson <alex.williamson@redhat.com> - 2016-07-18 19:40 +0200
        Re: [PATCH V9 4/9] vfio: platform: add support for ACPI probe Sinan Kaya <okaya@codeaurora.org> - 2016-07-18 23:30 +0200

csiph-web