Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1445510
| From | SF Markus Elfring <elfring@users.sourceforge.net> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | [PATCH v3] drm/ttm: Delete an unnecessary check before the function call "ttm_tt_destroy" |
| Date | 2016-07-18 16:20 +0200 |
| Message-ID | <rWhyN-7ha-17@gated-at.bofh.it> (permalink) |
| References | (6 earlier) <mSsDN-4wa-65@gated-at.bofh.it> <mSsDN-4wa-33@gated-at.bofh.it> <qvtgu-6H-15@gated-at.bofh.it> <rVg26-1P7-25@gated-at.bofh.it> <rWb0m-38e-5@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
From: Markus Elfring <elfring@users.sourceforge.net> Date: Mon, 18 Jul 2016 16:06:18 +0200 The ttm_tt_destroy() function tests whether its argument is NULL and then returns immediately. Thus the test around the call is not needed. This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring <elfring@users.sourceforge.net> --- drivers/gpu/drm/ttm/ttm_bo.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/gpu/drm/ttm/ttm_bo.c b/drivers/gpu/drm/ttm/ttm_bo.c index 39386f5..4e55863 100644 --- a/drivers/gpu/drm/ttm/ttm_bo.c +++ b/drivers/gpu/drm/ttm/ttm_bo.c @@ -146,9 +146,7 @@ static void ttm_bo_release_list(struct kref *list_kref) BUG_ON(bo->mem.mm_node != NULL); BUG_ON(!list_empty(&bo->lru)); BUG_ON(!list_empty(&bo->ddestroy)); - - if (bo->ttm) - ttm_tt_destroy(bo->ttm); + ttm_tt_destroy(bo->ttm); atomic_dec(&bo->glob->bo_count); if (bo->resv == &bo->ttm_resv) reservation_object_fini(&bo->ttm_resv); -- 2.9.2
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
[PATCH] drm/ttm: Delete an unnecessary check before the function call "ttm_tt_destroy" SF Markus Elfring <elfring@users.sourceforge.net> - 2016-07-15 20:30 +0200
Re: [PATCH] drm/ttm: Delete an unnecessary check before the function call "ttm_tt_destroy" Daniel Vetter <daniel@ffwll.ch> - 2016-07-18 09:20 +0200
[PATCH v3] drm/ttm: Delete an unnecessary check before the function call "ttm_tt_destroy" SF Markus Elfring <elfring@users.sourceforge.net> - 2016-07-18 16:20 +0200
Re: [PATCH v3] drm/ttm: Delete an unnecessary check before the function call "ttm_tt_destroy" Daniel Vetter <daniel@ffwll.ch> - 2016-07-18 16:50 +0200
Re: drm/ttm: Delete an unnecessary check before the function call "ttm_tt_destroy" SF Markus Elfring <elfring@users.sourceforge.net> - 2016-07-18 19:10 +0200
Re: [PATCH v3] drm/ttm: Delete an unnecessary check before the function call "ttm_tt_destroy" Geert Uytterhoeven <geert@linux-m68k.org> - 2016-07-19 10:20 +0200
Re: [PATCH v3] drm/ttm: Delete an unnecessary check before the function call "ttm_tt_destroy" Daniel Vetter <daniel@ffwll.ch> - 2016-07-19 10:30 +0200
csiph-web