Re: [PATCH] drm/hdlcd: Delete an unnecessary check before drm_fbdev_cma_hotplug_event()

From	Liviu Dudau <liviu.dudau@arm.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH] drm/hdlcd: Delete an unnecessary check before drm_fbdev_cma_hotplug_event()
Date	2016-07-18 11:30 +0200
Message-ID	<rWd29-4nL-3@gated-at.bofh.it> (permalink)
References	(5 earlier) <mSsDN-4wa-61@gated-at.bofh.it> <mSsDN-4wa-63@gated-at.bofh.it> <mSsDN-4wa-65@gated-at.bofh.it> <mSsDN-4wa-33@gated-at.bofh.it> <rVscV-S0-7@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Sat, Jul 16, 2016 at 09:20:02AM +0200, SF Markus Elfring wrote:
> From: Markus Elfring <elfring@users.sourceforge.net>
> Date: Sat, 16 Jul 2016 09:10:40 +0200
> 
> The drm_fbdev_cma_hotplug_event() function tests whether its argument
> is NULL and then returns immediately.
> Thus the test around the call is not needed.
> 
> This issue was detected by using the Coccinelle software.
> 
> Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>

Acked-by: Liviu Dudau <Liviu.Dudau@arm.com>

> ---
>  drivers/gpu/drm/arm/hdlcd_drv.c | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/drivers/gpu/drm/arm/hdlcd_drv.c b/drivers/gpu/drm/arm/hdlcd_drv.c
> index 28b8cd1..9b1aefe 100644
> --- a/drivers/gpu/drm/arm/hdlcd_drv.c
> +++ b/drivers/gpu/drm/arm/hdlcd_drv.c
> @@ -102,8 +102,7 @@ static void hdlcd_fb_output_poll_changed(struct drm_device *drm)
>  {
>  	struct hdlcd_drm_private *hdlcd = drm->dev_private;
>  
> -	if (hdlcd->fbdev)
> -		drm_fbdev_cma_hotplug_event(hdlcd->fbdev);
> +	drm_fbdev_cma_hotplug_event(hdlcd->fbdev);
>  }
>  
>  static const struct drm_mode_config_funcs hdlcd_mode_config_funcs = {
> -- 
> 2.9.1
> 
> _______________________________________________
> dri-devel mailing list
> dri-devel@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/dri-devel

-- 
====================
| I would like to |
| fix the world,  |
| but they're not |
| giving me the   |
 \ source code!  /
  ---------------
    ¯\_(ツ)_/¯

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH] drm/hdlcd: Delete an unnecessary check before  drm_fbdev_cma_hotplug_event() SF Markus Elfring <elfring@users.sourceforge.net> - 2016-07-16 09:30 +0200
  Re: [PATCH] drm/hdlcd: Delete an unnecessary check before  drm_fbdev_cma_hotplug_event() Liviu Dudau <liviu.dudau@arm.com> - 2016-07-18 11:30 +0200

csiph-web