Re: [Patch-V2 2/3] chcr: Support for Chelsio's Crypto Hardware

From	David Miller <davem@davemloft.net>
Newsgroups	linux.kernel
Subject	Re: [Patch-V2 2/3] chcr: Support for Chelsio's Crypto Hardware
Date	2016-07-20 06:20 +0200
Message-ID	<rWR9f-4VD-5@gated-at.bofh.it> (permalink)
References	<rWw4O-8qp-5@gated-at.bofh.it> <rWw4O-8qp-11@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

From: Yeshaswi M R Gowda <yeshaswi@chelsio.com>
Date: Mon, 18 Jul 2016 22:42:14 -0700

> +config CRYPTO_DEV_CHELSIO
> +	tristate "Chelsio Crypto Co-processor Driver"
> +	depends on PCI && NETDEVICES && ETHERNET
> +	select CRYPTO_SHA1
> +	select CRYPTO_SHA256
> +	select CRYPTO_SHA512
> +	select NET_VENDOR_CHELSIO
> +	select CHELSIO_T4

The user shouldn't have to know about the technical details about
how this chip is physically implemented.

It's therefore not reasonable to require an ethernet driver to be
enabled to use the crypto engine.

Also, selecting Kconfig symbol X does not recursively enable the
"select" statement(s) of symbol X nor does it check symbol X's
dependencies.

This is really one big huge dependency mess, and I think you have
to split out the core of the T4 driver into a driver subtype
agnostic library or similar to make this work properly.

Don't just shoehorn this stuff into the ethernet driver.  Round
peg, square hole.

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[Patch-V2 0/3] crypto/chcr: Add Chelsio Crypto Driver Yeshaswi M R Gowda <yeshaswi@chelsio.com> - 2016-07-19 07:50 +0200
  [Patch-V2 3/3] crypto: Added Chelsio Menu to the Kconfig file Yeshaswi M R Gowda <yeshaswi@chelsio.com> - 2016-07-19 07:50 +0200
  Re: [Patch-V2 2/3] chcr: Support for Chelsio's Crypto Hardware David Miller <davem@davemloft.net> - 2016-07-20 06:20 +0200

csiph-web