Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1446791

[RFC][PATCH 03/10 v2] k3dma: Fix "nobody cared" message seen on any error

Show all headers | View raw

From: Andy Green <andy.green@linaro.org>

As it was before, as soon as the DMAC IP felt there was an error
he would return IRQ_NONE since no actual transfer had completed.

After spinning on that for 100K interrupts, Linux yanks the IRQ with
a "nobody cared" error.

This patch lets it handle the interrupt and keep the IRQ alive.

Cc: Zhangfei Gao <zhangfei.gao@linaro.org>
Cc: Jingoo Han <jg1.han@samsung.com>
Cc: Krzysztof Kozlowski <k.kozlowski@samsung.com>
Cc: Maxime Ripard <maxime.ripard@free-electrons.com>
Cc: Vinod Koul <vinod.koul@intel.com>
Cc: Dan Williams <dan.j.williams@intel.com>
Cc: Liam Girdwood <lgirdwood@gmail.com>
Cc: Mark Brown <broonie@kernel.org>
Cc: Jaroslav Kysela <perex@perex.cz>
Cc: Takashi Iwai <tiwai@suse.com>
Cc: Wei Xu <xuwei5@hisilicon.com>
Cc: Rob Herring <robh+dt@kernel.org>
Cc: Andy Green <andy@warmcat.com>
Acked-by: Zhangfei Gao <zhangfei.gao@linaro.org>
Signed-off-by: Andy Green <andy.green@linaro.org>
[jstultz: Forward ported to mainline]
Signed-off-by: John Stultz <john.stultz@linaro.org>
---
 drivers/dma/k3dma.c | 8 +++++---
 1 file changed, 5 insertions(+), 3 deletions(-)

diff --git a/drivers/dma/k3dma.c b/drivers/dma/k3dma.c
index 8dd050c..c2906a82 100644
--- a/drivers/dma/k3dma.c
+++ b/drivers/dma/k3dma.c
@@ -220,11 +220,13 @@ static irqreturn_t k3_dma_int_handler(int irq, void *dev_id)
 	writel_relaxed(err1, d->base + INT_ERR1_RAW);
 	writel_relaxed(err2, d->base + INT_ERR2_RAW);
 
-	if (irq_chan) {
+	if (irq_chan)
 		tasklet_schedule(&d->task);
+
+	if (irq_chan || err1 || err2)
 		return IRQ_HANDLED;
-	} else
-		return IRQ_NONE;
+
+	return IRQ_NONE;
 }
 
 static int k3_dma_start_txd(struct k3_dma_chan *c)
-- 
1.9.1

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[RFC][PATCH 00/10 v2] Add HDMI audio support for HiKey John Stultz <john.stultz@linaro.org> - 2016-07-20 01:30 +0200
  [RFC][PATCH 02/10 v2] k3dma: Fix dma err offsets John Stultz <john.stultz@linaro.org> - 2016-07-20 01:30 +0200
  [RFC][PATCH 06/10 v2] ASoC: add hi6210-i2s  DT bindings John Stultz <john.stultz@linaro.org> - 2016-07-20 01:30 +0200
  [RFC][PATCH 01/10 v2] k3dma: Fix hisi burst clipping John Stultz <john.stultz@linaro.org> - 2016-07-20 01:30 +0200
  [RFC][PATCH 09/10 v2] ASoC: hisilicon: Add hi6210 hdmi codec driver John Stultz <john.stultz@linaro.org> - 2016-07-20 01:30 +0200
    Re: [RFC][PATCH 09/10 v2] ASoC: hisilicon: Add hi6210 hdmi codec  driver Mark Brown <broonie@kernel.org> - 2016-07-20 02:40 +0200
  [RFC][PATCH 03/10 v2] k3dma: Fix "nobody cared" message seen on any error John Stultz <john.stultz@linaro.org> - 2016-07-20 01:30 +0200
  [RFC][PATCH 04/10 v2] k3dma: Add cyclic mode for audio John Stultz <john.stultz@linaro.org> - 2016-07-20 01:30 +0200
  [RFC][PATCH 08/10 v2] ASoC: add hi6210-hdmi-audio-codec DT bindings John Stultz <john.stultz@linaro.org> - 2016-07-20 01:30 +0200
  [RFC][PATCH 10/10 v2] dts: hi6220: Add k3-dma and i2s/hdmi audio support John Stultz <john.stultz@linaro.org> - 2016-07-20 01:30 +0200
  [RFC][PATCH 07/10 v2] ASoC: hisilicon: Add hi6210 i2s audio driver John Stultz <john.stultz@linaro.org> - 2016-07-20 01:30 +0200
    Re: [RFC][PATCH 07/10 v2] ASoC: hisilicon: Add hi6210 i2s audio  driver Mark Brown <broonie@kernel.org> - 2016-07-20 02:30 +0200
      Re: [RFC][PATCH 07/10 v2] ASoC: hisilicon: Add hi6210 i2s audio driver John Stultz <john.stultz@linaro.org> - 2016-07-20 19:00 +0200
        Re: [RFC][PATCH 07/10 v2] ASoC: hisilicon: Add hi6210 i2s audio  driver Mark Brown <broonie@kernel.org> - 2016-07-20 19:10 +0200
  Re: [RFC][PATCH 00/10 v2] Add HDMI audio support for HiKey Mark Brown <broonie@kernel.org> - 2016-07-20 02:30 +0200

csiph-web