Re: [PATCH v3 4/4] vfs: Use dlock list for superblock's inode list

From	Tejun Heo <tj@kernel.org>
Newsgroups	linux.kernel
Subject	Re: [PATCH v3 4/4] vfs: Use dlock list for superblock's inode list
Date	2016-07-19 20:40 +0200
Message-ID	<rWI5Y-7uZ-31@gated-at.bofh.it> (permalink)
References	<rVfpn-1mA-3@gated-at.bofh.it> <rVfpo-1mA-27@gated-at.bofh.it> <rWvLr-8iu-9@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

Hello,

On Tue, Jul 19, 2016 at 06:23:42AM +0100, Al Viro wrote:
> On Fri, Jul 15, 2016 at 01:39:43PM -0400, Waiman Long wrote:
> > +		inode   = list_entry(iter.curr, struct inode, i_sb_list);
> > +		mapping = inode->i_mapping;
> 
> TBH, I would very much prefer something like
> 	DEFINE_DLOCK_LIST_ITER(iter, &blockdev_superblock->s_inodes);
> 
> 	dlist_for_each_entry(inode, &iter, i_sb_list) {
> 		mapping = inode->i_mapping;
> 
> > -		spin_unlock(&blockdev_superblock->s_inode_list_lock);
> > +		spin_unlock(iter.lock);
> 
> ... and this might be worth dlist_{un,re}lock(&iter);

If iterating requires prep / cleanup stages, it might as well do

	DEFINE_DLOCK_LIST_ITER(iter);

	dlock_list_iter_start(&iter, &blockdev_superblock->s_inodes);

	// iterate

	dlock_list_iter_end(&iter);

And probably provide dlist_for_each_entry() macro which handles
everything.

Thanks.

-- 
tejun

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH v3 4/4] vfs: Use dlock list for superblock's inode list Waiman Long <Waiman.Long@hpe.com> - 2016-07-15 19:50 +0200
  Re: [PATCH v3 4/4] vfs: Use dlock list for superblock's inode list Al Viro <viro@ZenIV.linux.org.uk> - 2016-07-19 07:30 +0200
    Re: [PATCH v3 4/4] vfs: Use dlock list for superblock's inode list Tejun Heo <tj@kernel.org> - 2016-07-19 20:40 +0200

csiph-web