Re: [RFC 02/18] cgroup_pids: track maximum pids

From	Topi Miettinen <toiwoton@gmail.com>
Newsgroups	linux.kernel
Subject	Re: [RFC 02/18] cgroup_pids: track maximum pids
Date	2016-07-17 22:20 +0200
Message-ID	<rW0HD-5da-1@gated-at.bofh.it> (permalink)
References	<rJG1X-2jr-7@gated-at.bofh.it> <rJG1X-2jr-17@gated-at.bofh.it> <rJHr3-3m2-1@gated-at.bofh.it> <rJHAK-3pk-21@gated-at.bofh.it> <rJHKp-3sH-13@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On 06/13/16 21:33, Tejun Heo wrote:
> Hello,
> 
> On Mon, Jun 13, 2016 at 09:29:32PM +0000, Topi Miettinen wrote:
>> I used fork callback as I don't want to lower the watermark in all cases
>> where the charge can be lowered, so I'd update the watermark only when
>> the fork really happens.
> 
> I don't think that would make a noticeable difference.  That's where
> we decide whether to grant fork or not after all and thus where the
> actual usage is.

I tried using only charge functions, but then the result was too low.
With fork callback, the result was as expected.

-Topi

> 
>> Is there a better way to compare and set? I don't think atomic_cmpxchg()
>> does what's needed,
> 
> cmpxchg loop should do what's necessary although I'm not sure how much
> being strictly correct matters here.
> 
> Thanks.
>

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

Re: [RFC 02/18] cgroup_pids: track maximum pids Topi Miettinen <toiwoton@gmail.com> - 2016-07-17 22:20 +0200
  Re: [RFC 02/18] cgroup_pids: track maximum pids Tejun Heo <tj@kernel.org> - 2016-07-19 03:10 +0200
    Re: [RFC 02/18] cgroup_pids: track maximum pids Topi Miettinen <toiwoton@gmail.com> - 2016-07-19 19:00 +0200
      Re: [RFC 02/18] cgroup_pids: track maximum pids Tejun Heo <tj@kernel.org> - 2016-07-19 20:20 +0200

csiph-web