Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1444642
| From | Arnaldo Carvalho de Melo <acme@kernel.org> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [patch 1/2] perf jit: add missing curly braces |
| Date | 2016-07-16 00:30 +0200 |
| Message-ID | <rVjMm-47e-3@gated-at.bofh.it> (permalink) |
| References | <rViwV-3rh-19@gated-at.bofh.it> <rVjMm-47e-5@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
Em Fri, Jul 15, 2016 at 07:25:56PM -0300, Arnaldo Carvalho de Melo escreveu:
> Em Sat, Jul 16, 2016 at 12:07:12AM +0300, Dan Carpenter escreveu:
> > It doesn't change the runtime behavior, but my static checker complains
> > that curly braces were intended.
>
> Agreed, applying, thanks!
After fixing this:
[acme@jouet linux]$ am /wb/1.patch
Applying: perf jit: add missing curly braces
fatal: patch with only garbage at line 3
Patch failed at 0001 perf jit: add missing curly braces
> - Arnaldo
>
> > Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
> >
> > diff --git a/tools/perf/jvmti/jvmti_agent.c b/tools/perf/jvmti/jvmti_agent.c
> > index 3573f31..91bf333 100644
> > --- a/tools/perf/jvmti/jvmti_agent.c
> > +++ b/tools/perf/jvmti/jvmti_agent.c
> > @@ -491,10 +491,11 @@ jvmti_write_debug_info(void *agent, uint64_t code, const char *file,
> > if (sret != 1)
> > goto error;
> > }
> > - if (padding_count)
> > + if (padding_count) {
> > sret = fwrite_unlocked(pad_bytes, padding_count, 1, fp);
> > if (sret != 1)
> > goto error;
> > + }
> >
> > funlockfile(fp);
> > return 0;
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
[patch 1/2] perf jit: add missing curly braces Dan Carpenter <dan.carpenter@oracle.com> - 2016-07-15 23:10 +0200 Re: [patch 1/2] perf jit: add missing curly braces Arnaldo Carvalho de Melo <acme@kernel.org> - 2016-07-16 00:30 +0200 Re: [patch 1/2] perf jit: add missing curly braces Arnaldo Carvalho de Melo <acme@kernel.org> - 2016-07-16 00:30 +0200 Re: [patch 1/2] perf jit: add missing curly braces Stephane Eranian <eranian@google.com> - 2016-07-16 18:40 +0200 [tip:perf/core] perf jit: Add missing curly braces tip-bot for Dan Carpenter <tipbot@zytor.com> - 2016-07-19 09:00 +0200
csiph-web