RE: [PATCH] dmaengine: zynqmp_dma: Fix static checker warning

From	Appana Durga Kedareswara Rao <appana.durga.rao@xilinx.com>
Newsgroups	linux.kernel
Subject	RE: [PATCH] dmaengine: zynqmp_dma: Fix static checker warning
Date	2016-07-13 14:10 +0200
Message-ID	<rUr9f-2Tk-7@gated-at.bofh.it> (permalink)
References	<rUpTQ-1UQ-21@gated-at.bofh.it> <rUqGd-2sM-13@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

Hi Dan,

	Thanks for the review...

> On Wed, Jul 13, 2016 at 04:12:16PM +0530, Kedareswara rao Appana wrote:
> > diff --git a/drivers/dma/xilinx/zynqmp_dma.c
> > b/drivers/dma/xilinx/zynqmp_dma.c index f777a5b..2248704 100644
> > --- a/drivers/dma/xilinx/zynqmp_dma.c
> > +++ b/drivers/dma/xilinx/zynqmp_dma.c
> > @@ -970,8 +970,13 @@ static int zynqmp_dma_chan_probe(struct
> zynqmp_dma_device *zdev,
> >  	chan->dst_burst_len = ZYNQMP_DMA_AWLEN_RST_VAL;
> >  	chan->src_burst_len = ZYNQMP_DMA_ARLEN_RST_VAL;
> >  	err = of_property_read_u32(node, "xlnx,bus-width", &chan-
> >bus_width);
> > -	if ((err < 0) && ((chan->bus_width != ZYNQMP_DMA_BUS_WIDTH_64) ||
> > -			  (chan->bus_width !=
> ZYNQMP_DMA_BUS_WIDTH_128))) {
> > +	if (err < 0) {
> > +		dev_err(&pdev->dev, "missing xlnx,bus-width property\n");
> > +		return err;
> > +	}
> > +
> > +	if ((chan->bus_width != ZYNQMP_DMA_BUS_WIDTH_64) ||
> 
> This has to be an && because it can never be both widths.  You didn't test this
> patch.  Also too many parenthesis (you're thinking of LISP).

Will fix in the next version...

> 
> > +	    (chan->bus_width != ZYNQMP_DMA_BUS_WIDTH_128)) {
> >  		dev_err(zdev->dev, "invalid bus-width value");
> >  		return err;
> 
> This has to be a negative error code.

Will fix in the next version...

Regards,
Kedar.

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH] dmaengine: zynqmp_dma: Fix static checker warning Kedareswara rao Appana <appana.durga.rao@xilinx.com> - 2016-07-13 12:50 +0200
  Re: [PATCH] dmaengine: zynqmp_dma: Fix static checker warning Dan Carpenter <dan.carpenter@oracle.com> - 2016-07-13 13:40 +0200
    RE: [PATCH] dmaengine: zynqmp_dma: Fix static checker warning Appana Durga Kedareswara Rao <appana.durga.rao@xilinx.com> - 2016-07-13 14:10 +0200

csiph-web