Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1439944

Re: [PATCH] kbuild: Abort build on bad stack protector flag

Show all headers | View raw

* Kees Cook <keescook@chromium.org> wrote:

> Before, the stack protector flag was sanity checked before .config had
> been reprocessed. This meant the build couldn't be aborted early, and
> only a warning could be emitted followed later by the compiler blowing
> up with an unknown flag. This has caused a lot of confusion over time,
> so this splits the flag selection from sanity checking and performs the
> sanity checking after the make has been restarted from a reprocessed
> .config, so builds can be aborted as early as possible now.
> 
> Additionally moves the x86-specific sanity check to the same location,
> since it suffered from the same warn-then-wait-for-compiler-failure
> problem.
> 
> Signed-off-by: Kees Cook <keescook@chromium.org>
> ---
>  Makefile          | 69 +++++++++++++++++++++++++++++++++----------------------
>  arch/x86/Makefile |  8 -------
>  2 files changed, 42 insertions(+), 35 deletions(-)

What's the status of this patch? I can merge it if Michal acks the main Makefile 
bits.

Thanks,

	Ingo

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

Re: [PATCH] kbuild: Abort build on bad stack protector flag Ingo Molnar <mingo@kernel.org> - 2016-07-09 14:10 +0200
  Re: [PATCH] kbuild: Abort build on bad stack protector flag Kees Cook <keescook@chromium.org> - 2016-07-09 19:00 +0200

csiph-web