[PATCH] mtd: nand: brcmnand: Change BUG_ON in brcmnand_send_cmd

From	Florian Fainelli <f.fainelli@gmail.com>
Newsgroups	linux.kernel
Subject	[PATCH] mtd: nand: brcmnand: Change BUG_ON in brcmnand_send_cmd
Date	2016-07-08 19:40 +0200
Message-ID	<rSHUT-7Ss-49@gated-at.bofh.it> (permalink)
Organization	linux.* mail to news gateway

Show all headers | View raw

Change the BUG_ON() condition in brcmnand_send_cmd() which checks for
the interrupt status "controller ready" bit to a WARN_ON.

There is no good reason to kill the system when this condition occur
because we could have systems which listed the NAND controller as
available (e.g: from Device Tree), but the NAND chip could be
malfunctioning and not responding.

Signed-off-by: Florian Fainelli <f.fainelli@gmail.com>
---
Note that I even hesitated to remove that completely, but there is
some value in knowing about this condition since it helps figuring
out what could be wrong.

 drivers/mtd/nand/brcmnand/brcmnand.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/mtd/nand/brcmnand/brcmnand.c b/drivers/mtd/nand/brcmnand/brcmnand.c
index b6062a2f3dfd..72bdc283778d 100644
--- a/drivers/mtd/nand/brcmnand/brcmnand.c
+++ b/drivers/mtd/nand/brcmnand/brcmnand.c
@@ -1165,7 +1165,7 @@ static void brcmnand_send_cmd(struct brcmnand_host *host, int cmd)
 	ctrl->cmd_pending = cmd;
 
 	intfc = brcmnand_read_reg(ctrl, BRCMNAND_INTFC_STATUS);
-	BUG_ON(!(intfc & INTFC_CTLR_READY));
+	WARN_ON(!(intfc & INTFC_CTLR_READY));
 
 	mb(); /* flush previous writes */
 	brcmnand_write_reg(ctrl, BRCMNAND_CMD_START,
-- 
2.7.4

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

[PATCH] mtd: nand: brcmnand: Change BUG_ON in brcmnand_send_cmd Florian Fainelli <f.fainelli@gmail.com> - 2016-07-08 19:40 +0200
  Re: [PATCH] mtd: nand: brcmnand: Change BUG_ON in brcmnand_send_cmd Brian Norris <computersforpeace@gmail.com> - 2016-07-10 03:40 +0200
    Re: [PATCH] mtd: nand: brcmnand: Change BUG_ON in brcmnand_send_cmd Kamal Dasu <kamal.dasu@broadcom.com> - 2016-07-11 17:40 +0200
  Re: [PATCH] mtd: nand: brcmnand: Change BUG_ON in brcmnand_send_cmd Brian Norris <computersforpeace@gmail.com> - 2016-07-17 05:50 +0200

csiph-web