Re: [PATCH 1/1] usb: quirks: Add no-lpm quirk for Elan Microelectronics Touchpad

From	Joseph Salisbury <joseph.salisbury@canonical.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH 1/1] usb: quirks: Add no-lpm quirk for Elan Microelectronics Touchpad
Date	2016-07-07 02:30 +0200
Message-ID	<rS5mx-7SX-5@gated-at.bofh.it> (permalink)
References	<rS31n-6fe-5@gated-at.bofh.it> <rS31n-6fe-3@gated-at.bofh.it> <rS4gN-7eR-1@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On 07/06/2016 07:10 PM, Greg KH wrote:
> On Wed, Jul 06, 2016 at 05:53:47PM -0400, Joseph Salisbury wrote:
>> BugLink: http://bugs.launchpad.net/bugs/1498667
>>
>> As reported in BugLink, this device has an issue with Linux Power Management so 
>> adding a quirk.  This quirk was reccomended by Alan Stern:
>>
>> http://lkml.iu.edu/hypermail/linux/kernel/1606.2/05590.html
>>
>> Signed-off-by: Joseph Salisbury <joseph.salisbury@canonical.com>
>> Cc: stable <stable@vger.kernel.org>
>>
>> ---
>>  drivers/usb/core/quirks.c | 3 +++
>>  1 file changed, 3 insertions(+)
>>
>> diff --git a/drivers/usb/core/quirks.c b/drivers/usb/core/quirks.c
>> index 944a6dc..a33d003 100644
>> --- a/drivers/usb/core/quirks.c
>> +++ b/drivers/usb/core/quirks.c
>> @@ -198,6 +198,9 @@ static const struct usb_device_id usb_quirk_list[] = {
>>  	/* Protocol and OTG Electrical Test Device */
>>  	{ USB_DEVICE(0x1a0a, 0x0200), .driver_info =
>>  			USB_QUIRK_LINEAR_UFRAME_INTR_BINTERVAL },
>> +
>> +	/* ELAN Microelectronics Touchscreen */
>> +	{ USB_DEVICE(0x04f3, 0x0381), .driver_info = USB_QUIRK_NO_LPM },
> Please put this next to the other Elan touchscreen quirk entries, don't
> put them in random order, it's a pain to maintain that way...
>
> thanks,
>
> greg k-h
Sorry, I grouped it with the other USB_QUIRK_NO_LPM entries.  I'll send
a V2 patch and make a note to group by manufacturer from now on.

Thanks,

Joe

Thread

[PATCH 1/1] usb: quirks: Add no-lpm quirk for Elan Microelectronics Touchpad Joseph Salisbury <joseph.salisbury@canonical.com> - 2016-07-07 00:00 +0200
  Re: [PATCH 1/1] usb: quirks: Add no-lpm quirk for Elan  Microelectronics Touchpad Greg KH <gregkh@linuxfoundation.org> - 2016-07-07 01:20 +0200
    Re: [PATCH 1/1] usb: quirks: Add no-lpm quirk for Elan  Microelectronics Touchpad Joseph Salisbury <joseph.salisbury@canonical.com> - 2016-07-07 02:30 +0200
  Re: [PATCH 1/1] usb: quirks: Add no-lpm quirk for Elan  Microelectronics Touchpad Lu Baolu <baolu.lu@linux.intel.com> - 2016-07-08 03:10 +0200

csiph-web