Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1436952
| From | Fabio Estevam <festevam@gmail.com> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [PATCH 2/3] ARM: dts: imx6sx: Add UDOO Neo support |
| Date | 2016-07-05 14:10 +0200 |
| Message-ID | <rRxkR-2C5-5@gated-at.bofh.it> (permalink) |
| References | <rRpQl-6gQ-5@gated-at.bofh.it> <rRpQl-6gQ-11@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
On Tue, Jul 5, 2016 at 1:04 AM, Andreas Färber <afaerber@suse.de> wrote:
> +/dts-v1/;
> +
> +#include "imx6sx-udoo-neo.dtsi"
> +
> +/ {
> + model = "UDOO Neo Basic";
This should be something like:
model = "Udoo i.MX6 SoloX UDOO Neo Basic";
> + compatible = "fsl,imx6sx";
compatible = "udoo,imx6sx-udoo-neo", "fsl,imx6sx";
Then you can also send a separate patch to add udoo to
Documentation/devicetree/bindings/vendor-prefixes.txt.
Same applies to other places in this patch.
> +&fec1 {
> + pinctrl-names = "default";
> + pinctrl-0 = <&pinctrl_enet1>;
> + phy-mode = "rmii";
> + phy-reset-gpios = <&gpio5 4 GPIO_ACTIVE_HIGH>;
Shouldn't this be GPIO_ACTIVE_LOW instead?
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
[PATCH 2/3] ARM: dts: imx6sx: Add UDOO Neo support Andreas Färber <afaerber@suse.de> - 2016-07-05 06:10 +0200
Re: [PATCH 2/3] ARM: dts: imx6sx: Add UDOO Neo support Uwe Kleine-König <u.kleine-koenig@pengutronix.de> - 2016-07-05 08:30 +0200
Re: [PATCH 2/3] ARM: dts: imx6sx: Add UDOO Neo support Andreas Färber <afaerber@suse.de> - 2016-07-05 16:50 +0200
Re: [PATCH 2/3] ARM: dts: imx6sx: Add UDOO Neo support Fabio Estevam <festevam@gmail.com> - 2016-07-05 14:10 +0200
Re: [PATCH 2/3] ARM: dts: imx6sx: Add UDOO Neo support Andreas Färber <afaerber@suse.de> - 2016-07-05 16:00 +0200
Re: [PATCH 2/3] ARM: dts: imx6sx: Add UDOO Neo support Uwe Kleine-König <u.kleine-koenig@pengutronix.de> - 2016-07-05 20:40 +0200
csiph-web