Re: [RFC PATCH v2 1/9] mailbox: Add Amlogic Meson Message-Handling-Unit

From	Jassi Brar <jassisinghbrar@gmail.com>
Newsgroups	linux.kernel
Subject	Re: [RFC PATCH v2 1/9] mailbox: Add Amlogic Meson Message-Handling-Unit
Date	2016-07-04 17:30 +0200
Message-ID	<rRdYR-7jy-3@gated-at.bofh.it> (permalink)
References	(2 earlier) <rMI7f-76A-3@gated-at.bofh.it> <rNf3b-3EH-5@gated-at.bofh.it> <rO026-8sG-15@gated-at.bofh.it> <rP1S9-88I-7@gated-at.bofh.it> <rP2Od-hD-15@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Tue, Jun 28, 2016 at 8:36 PM, Jassi Brar <jassisinghbrar@gmail.com> wrote:
> On Tue, Jun 28, 2016 at 7:30 PM, Neil Armstrong <narmstrong@baylibre.com> wrote:

>>
>> My main question is : do you really want to transform this simple driver into
>> a dirty multi-bus generic mailbox driver ?
>> The meson_mhu is only 199 lines and this patch adds 181 lines to the arm_mhu driver.
>>
>> I'll personally push to have two separate drivers here.
>>
> It is a shame if we need to copy a driver only due to changed register
> offsets. Let me give it a shot and see how worse off we would be.
>
OK, so I trimmed the differences further but it still doesn't look any
better. The best approach seems to be have a separate driver but with
consideration that its a 3rd party IP and hence likely to be used by
other platforms. That is, call it something meson-neutral. I will make
a few comments on the patch post.

Thanks

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

Re: [RFC PATCH v2 1/9] mailbox: Add Amlogic Meson Message-Handling-Unit Jassi Brar <jassisinghbrar@gmail.com> - 2016-06-25 20:00 +0200
  Re: [RFC PATCH v2 1/9] mailbox: Add Amlogic Meson  Message-Handling-Unit Neil Armstrong <narmstrong@baylibre.com> - 2016-06-28 16:10 +0200
    Re: [RFC PATCH v2 1/9] mailbox: Add Amlogic Meson Message-Handling-Unit Jassi Brar <jassisinghbrar@gmail.com> - 2016-06-28 17:10 +0200
      Re: [RFC PATCH v2 1/9] mailbox: Add Amlogic Meson Message-Handling-Unit Jassi Brar <jassisinghbrar@gmail.com> - 2016-07-04 17:30 +0200

csiph-web