Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1437246

Re: [PATCH] tracing: Have HIST_TRIGGERS select TRACING

Show all headers | View raw

On Sun, 03 Jul 2016 08:51:34 -0500
Tom Zanussi <tom.zanussi@linux.intel.com> wrote:

> The kbuild test robot reported a compile error if HIST_TRIGGERS was
> enabled but nothing else that selected TRACING was configured in.
> 
> HIST_TRIGGERS should directly select it and not rely on anything else
> to do it.
> 

I added:

Reported-by: kbuild test robot <fennguang.wu@intel.com>
Fixes: 7ef224d1d0e3a ("tracing: Add 'hist' event trigger command")


This isn't that big of a deal, so I'm just going to put it into my
queue for the next merge window.

-- Steve


> Signed-off-by: Tom Zanussi <tom.zanussi@linux.intel.com>
> ---
>  kernel/trace/Kconfig | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/kernel/trace/Kconfig b/kernel/trace/Kconfig
> index fafeaf8..f4b86e8 100644
> --- a/kernel/trace/Kconfig
> +++ b/kernel/trace/Kconfig
> @@ -542,6 +542,7 @@ config HIST_TRIGGERS
>  	bool "Histogram triggers"
>  	depends on ARCH_HAVE_NMI_SAFE_CMPXCHG
>  	select TRACING_MAP
> +	select TRACING
>  	default n
>  	help
>  	  Hist triggers allow one or more arbitrary trace event fields

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH] tracing: Have HIST_TRIGGERS select TRACING Tom Zanussi <tom.zanussi@linux.intel.com> - 2016-07-03 16:00 +0200
  Re: [PATCH] tracing: Have HIST_TRIGGERS select TRACING Steven Rostedt <rostedt@goodmis.org> - 2016-07-05 21:50 +0200

csiph-web