Re: [PATCH v10 07/22] IB/hns: Add event queue support

From	Leon Romanovsky <leon@kernel.org>
Newsgroups	linux.kernel
Subject	Re: [PATCH v10 07/22] IB/hns: Add event queue support
Date	2016-06-29 12:50 +0200
Message-ID	<rPlea-36J-25@gated-at.bofh.it> (permalink)
References	<rKGsW-11v-3@gated-at.bofh.it> <rKGsW-11v-39@gated-at.bofh.it> <rNBwK-1xi-7@gated-at.bofh.it> <rPjvH-1Zc-1@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

[Multipart message — attachments visible in raw view] - view raw

On Wed, Jun 29, 2016 at 04:53:39PM +0800, oulijun wrote:

> >> +
> >> +	for (i = 0; i < npages; ++i)
> >> +		if (eq->buf_list[i].buf)
> > 
> > Is it possible situation to have eq->buf_list[i].buf == NULL at the
> > middle of iteration?
> > 
> We have analysized it according to your reivews. We think that the eq->buf_list[i].buf
> is not NULL at the middle of iteration because only the eq->buf_list[i].buf allocated
> when the hns_roce_free_eq be called. As result, the if (eq->buf_list[i].buf) condition
> should be deleted, right?

Yes, please.

Back to linux.kernel | Previous | Next | Find similar | Unroll thread

Thread

Re: [PATCH v10 07/22] IB/hns: Add event queue support Leon Romanovsky <leon@kernel.org> - 2016-06-29 12:50 +0200

csiph-web