Re: [PATCH v4 1/3] ASoC: tegra: add tegra sgtl5000 machine driver

From	Rob Herring <robh@kernel.org>
Newsgroups	linux.kernel
Subject	Re: [PATCH v4 1/3] ASoC: tegra: add tegra sgtl5000 machine driver
Date	2016-06-30 15:50 +0200
Message-ID	<rPKvT-1LB-7@gated-at.bofh.it> (permalink)
References	<rLzpn-3nt-7@gated-at.bofh.it> <rLzpn-3nt-23@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Sun, Jun 19, 2016 at 03:00:00AM +0200, Marcel Ziswiler wrote:
> This binding and driver describe/support playback to headphones, and
> capture from line-in and microphone.
> 
> This driver is useful for the Toradex Apalis T30, Apalis TK1 and
> Colibri T30 modules.
> 
> Signed-off-by: Marcel Ziswiler <marcel@ziswiler.com>
> Reviewed-by: Stephen Warren <swarren@nvidia.com>
> 
> Signed-off-by: Marcel Ziswiler <marcel.ziswiler@toradex.com>
> ---
> 
> Changes in v4:
> - simple-audio-card does still not allow for more advanced use cases
>   like Tegra SoCs
> - further platform drivers have been accepted since my last attempt
>   (e.g. rt5677 one)
> - relevance for one further board the new Toradex Apalis TK1
> - drop unused sound/jack.h include
> - in tegra_sgtl5000_driver_remove() pass return value of
>   snd_soc_unregister_card() on to caller
> - no longer set owner property in platform_driver to THIS_MODULE
> - re-based/resend
> 
> Changes in v3:
> - revert to not using simple-audio-card being incompatible with tegra
> - rebased to for-next
> 
> Changes in v2:
> - using simple-audio-card as suggested by Fabio
> 
>  .../bindings/sound/nvidia,tegra-audio-sgtl5000.txt |  42 ++++

Acked-by: Rob Herring <robh@kernel.org>

>  sound/soc/tegra/Kconfig                            |  11 ++
>  sound/soc/tegra/Makefile                           |   2 +
>  sound/soc/tegra/tegra_sgtl5000.c                   | 212 +++++++++++++++++++++
>  4 files changed, 267 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/sound/nvidia,tegra-audio-sgtl5000.txt
>  create mode 100644 sound/soc/tegra/tegra_sgtl5000.c

Back to linux.kernel | Previous | Next | Find similar | Unroll thread

Thread

Re: [PATCH v4 1/3] ASoC: tegra: add tegra sgtl5000 machine driver Rob Herring <robh@kernel.org> - 2016-06-30 15:50 +0200

csiph-web