Groups > linux.kernel > #1431952

Re: powerpc/fadump: trivial fix of spelling mistake, clean up message

From	Michael Ellerman <mpe@ellerman.id.au>
Newsgroups	linux.kernel
Subject	Re: powerpc/fadump: trivial fix of spelling mistake, clean up message
Date	2016-06-27 13:30 +0200
Message-ID	<rOCTM-809-29@gated-at.bofh.it> (permalink)
References	<rO9I5-6oK-9@gated-at.bofh.it> <rOC7o-7sH-39@gated-at.bofh.it> <rOCqJ-7A9-17@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Mon, 2016-06-27 at 03:51 -0700, Joe Perches wrote:
> On Mon, 2016-06-27 at 11:38 +0100, Colin Ian King wrote:
> > On 26/06/16 05:19, Michael Ellerman wrote:
> > > On Fri, 2016-24-06 at 17:43:00 UTC, Colin King wrote:
> > > > trivial fix to spelling mistake "rgistration" and minor clean up
> > > > of the printk error message
> > > Can you also:
> > >  - use pr_err()
> > >  - unsplit the message, ie. keep the string all on one line.
> > I can unsplit the string, but checkpatch will complain about that, so
> > I'm not sure if that's preferred or not.
> > 
> > WARNING: line over 80 characters
> 
> If the statement is wrapped after the format,
> then checkpatch shouldn't complain.
> 
> 	pr_err("Failed to invalidate firmware-assisted dump registration. Unexpected error (%d).\n",
> 	       rc);

But that's not actually any more readable, so just ignore checkpatch in this
case IMHO. It's a guide, not the gospel.

cheers

Thread

[PATCH] powerpc/fadump: trivial fix of spelling mistake, clean up message Colin King <colin.king@canonical.com> - 2016-06-24 19:50 +0200
  Re: powerpc/fadump: trivial fix of spelling mistake, clean up message Michael Ellerman <mpe@ellerman.id.au> - 2016-06-26 06:20 +0200
    Re: powerpc/fadump: trivial fix of spelling mistake, clean up message Colin Ian King <colin.king@canonical.com> - 2016-06-27 12:40 +0200
      Re: powerpc/fadump: trivial fix of spelling mistake, clean up  message Joe Perches <joe@perches.com> - 2016-06-27 13:00 +0200
        Re: powerpc/fadump: trivial fix of spelling mistake, clean up  message Michael Ellerman <mpe@ellerman.id.au> - 2016-06-27 13:30 +0200
          Re: powerpc/fadump: trivial fix of spelling mistake, clean up  message Joe Perches <joe@perches.com> - 2016-06-27 13:40 +0200
          Re: powerpc/fadump: trivial fix of spelling mistake, clean up message Colin Ian King <colin.king@canonical.com> - 2016-06-27 13:40 +0200
            Re: powerpc/fadump: trivial fix of spelling mistake, clean up  message Michael Ellerman <mpe@ellerman.id.au> - 2016-06-28 06:00 +0200

csiph-web