Re: [PATCH v4 3/8] iommu/rockchip: Fix allocation of bases array in driver probe

From	Doug Anderson <dianders@chromium.org>
Newsgroups	linux.kernel
Subject	Re: [PATCH v4 3/8] iommu/rockchip: Fix allocation of bases array in driver probe
Date	2016-06-21 19:30 +0200
Message-ID	<rMxES-lN-9@gated-at.bofh.it> (permalink)
References	<rMlDH-YU-3@gated-at.bofh.it> <rMlDH-YU-7@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

Hi,

On Mon, Jun 20, 2016 at 9:34 PM, Tomasz Figa <tfiga@chromium.org> wrote:
> From: Shunqian Zheng <zhengsq@rock-chips.com>
>
> In .probe(), devm_kzalloc() is called with size == 0 and works only
> by luck, due to internal behavior of the allocator and the fact
> that the proper allocation size is small. Let's use proper value for
> calculating the size.
>
> Fixes: cd6438c5f844 ("iommu/rockchip: Reconstruct to support multi slaves")
>
> Signed-off-by: Shunqian Zheng <zhengsq@rock-chips.com>
> Signed-off-by: Tomasz Figa <tfiga@chromium.org>
> ---
>  drivers/iommu/rockchip-iommu.c | 6 ++++--
>  1 file changed, 4 insertions(+), 2 deletions(-)

Reviewed-by: Douglas Anderson <dianders@chromium.org>

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH v4 3/8] iommu/rockchip: Fix allocation of bases array in driver probe Tomasz Figa <tfiga@chromium.org> - 2016-06-21 06:40 +0200
  Re: [PATCH v4 3/8] iommu/rockchip: Fix allocation of bases array in  driver probe Doug Anderson <dianders@chromium.org> - 2016-06-21 19:30 +0200

csiph-web