Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1427547

RE: [PATCH v4 1/5] ACPICA: Namespace: Fix a regression that MLC support triggers dead lock in dynamic table loading

Show all headers | View raw

Hi, Mika

> From: Mika Westerberg [mailto:mika.westerberg@linux.intel.com]
> Subject: Re: [PATCH v4 1/5] ACPICA: Namespace: Fix a regression that MLC
> support triggers dead lock in dynamic table loading
> 
> On Tue, Jun 21, 2016 at 12:34:15PM +0800, Lv Zheng wrote:
> > The new MLC approach invokes MLC per-table basis. But the dynamic
> loading
> > support of this is incorrect because of the lock order:
> >  acpi_ns_evaluate
> >    acpi_ex_enter_intperter
> >      acpi_ns_load_table (triggered by Load opcode)
> >        acpi_ns_exec_module_code_list
> >          acpi_ex_enter_intperter
> > The regression is introduced by the following commit:
> >   Commit: 2785ce8d0da1cac9d8f78615e116cf929e9a9123
> >   ACPICA Commit: 071eff738c59eda1792ac24b3b688b61691d7e7c
> >   Subject: ACPICA: Add per-table execution of module-level code
> > This patch fixes this regression by unlocking the interpreter lock before
> > invoking MLC. However the unlocking is done to the
> acpi_ns_load_table(), in
> > which, the interpreter lock should be locked by acpi_ns_parse_table()
> but
> > wasn't. Reported by Mika Westerberg. Fixed by Lv Zheng.
> >
> > Fixes: 2785ce8d0da1 ("ACPICA: Add per-table execution of module-level
> code")
> > Cc: Mika Westerberg <mika.westerberg@linux.intel.com>
> > Reported-by: Mika Westerberg <mika.westerberg@linux.intel.com>
> 
> Now builds fine and fixes the hang, thanks :)
> 
> Tested-by: Mika Westerberg <mika.westerberg@linux.intel.com>
[Lv Zheng] 
Great! :)
I'll leave the SOB correction for Rafael in order not to bother others by re-sending an update.

Thanks and best regards
-Lv

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH v4 0/5] ACPI 2.0: Enable TermList interpretion for table loading Lv Zheng <lv.zheng@intel.com> - 2016-06-21 06:40 +0200
  [PATCH v4 4/5] ACPI 2.0 / AML: Enable correct ACPI subsystem initialization order for new table loading mode Lv Zheng <lv.zheng@intel.com> - 2016-06-21 06:40 +0200
  [PATCH v4 2/5] ACPICA: Dispatcher: Fix an issue that the opregions created by the linked MLC were not tracked Lv Zheng <lv.zheng@intel.com> - 2016-06-21 06:40 +0200
  [PATCH v4 1/5] ACPICA: Namespace: Fix a regression that MLC support triggers dead lock in dynamic table loading Lv Zheng <lv.zheng@intel.com> - 2016-06-21 06:40 +0200
    Re: [PATCH v4 1/5] ACPICA: Namespace: Fix a regression that MLC  support triggers dead lock in dynamic table loading Mika Westerberg <mika.westerberg@linux.intel.com> - 2016-06-21 10:10 +0200
      RE: [PATCH v4 1/5] ACPICA: Namespace: Fix a regression that MLC  support triggers dead lock in dynamic table loading "Zheng, Lv" <lv.zheng@intel.com> - 2016-06-21 12:10 +0200
        Re: [PATCH v4 1/5] ACPICA: Namespace: Fix a regression that MLC support triggers dead lock in dynamic table loading "Rafael J. Wysocki" <rjw@rjwysocki.net> - 2016-06-23 02:40 +0200
  [PATCH v4 5/5] ACPI 2.0 / AML: Fix module level execution by correctly parsing table as TermList Lv Zheng <lv.zheng@intel.com> - 2016-06-21 06:40 +0200
  [PATCH v4 3/5] ACPICA: ACPI 2.0, Interpreter: Fix MLC issues by switching to new TermList grammar for table loading Lv Zheng <lv.zheng@intel.com> - 2016-06-21 06:40 +0200

csiph-web