Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1426976

Re: [PATCH] memcg: mem_cgroup_migrate() may be called with irq disabled

From Johannes Weiner <hannes@cmpxchg.org>
Newsgroups linux.kernel
Subject Re: [PATCH] memcg: mem_cgroup_migrate() may be called with irq disabled
Date 2016-06-20 22:00 +0200
Message-ID <rMdwu-44L-33@gated-at.bofh.it> (permalink)
References <rM5pf-7ws-15@gated-at.bofh.it> <rMcAq-3vm-5@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw


On Mon, Jun 20, 2016 at 02:41:58PM -0400, Tejun Heo wrote:
> mem_cgroup_migrate() uses local_irq_disable/enable() but can be called
> with irq disabled from migrate_page_copy().  This ends up enabling irq
> while holding a irq context lock triggering the following lockdep
> warning.  Fix it by using irq_save/restore instead.

Acked-by: Johannes Weiner <hannes@cmpxchg.org>

Fixes: 74485cf2bc85 ("mm: migrate: consolidate mem_cgroup_migrate() calls")
CC: stable@vger.kernel.org # 4.5

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread


Thread

4.7-rc1: lockdep: inconsistent lock state  kcompactd/aio_migratepage/mem_cgroup_migrate.... Christian Borntraeger <borntraeger@de.ibm.com> - 2016-06-20 13:20 +0200
  [PATCH] memcg: mem_cgroup_migrate() may be called with irq disabled Tejun Heo <tj@kernel.org> - 2016-06-20 21:00 +0200
    Re: [PATCH] memcg: mem_cgroup_migrate() may be called with irq  disabled Johannes Weiner <hannes@cmpxchg.org> - 2016-06-20 22:00 +0200
    Re: [PATCH] memcg: mem_cgroup_migrate() may be called with irq  disabled Christian Borntraeger <borntraeger@de.ibm.com> - 2016-06-20 22:40 +0200
    Re: [PATCH] memcg: mem_cgroup_migrate() may be called with irq  disabled Michal Hocko <mhocko@kernel.org> - 2016-06-21 10:50 +0200

csiph-web