Re: [PATCH v6 3/6] crypto: AF_ALG -- add asymmetric cipher interface

From	Mat Martineau <mathew.j.martineau@linux.intel.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH v6 3/6] crypto: AF_ALG -- add asymmetric cipher interface
Date	2016-06-23 01:10 +0200
Message-ID	<rMZrs-1su-45@gated-at.bofh.it> (permalink)
References	<rzg8R-u7-93@gated-at.bofh.it> <rIcSm-1Dx-15@gated-at.bofh.it> <rIcSm-1Dx-17@gated-at.bofh.it> <rId21-1Hc-5@gated-at.bofh.it> <rIvUZ-5O9-11@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

Stephan and Tadeusz,

On Fri, 10 Jun 2016, Tadeusz Struk wrote:

> On 06/09/2016 11:36 AM, Stephan Mueller wrote:
>> Am Donnerstag, 9. Juni 2016, 11:27:13 schrieb Mat Martineau:
>>
>> Hi Mat, Tadeusz,
>>
>> Ok, after checking the code again, I think that dropping that sanity check
>> should be ok given that this length is part of the akcipher API.
>>
>> Tadeusz, as you are currently managing that patch set, would you re-spin it
>> with the following check removed?
>>
>> +     if (usedpages < akcipher_calcsize(ctx)) {
>> +             err = -EMSGSIZE;
>> +             goto unlock;
>> +     }
>>
>
> Ok, I'll update the patch.

Thanks, that helps (especially with pkcs1pad).

This brings me to another proposal for read buffer sizing: AF_ALG akcipher 
can guarantee that partial reads (where the read buffer is shorter than 
the output of the crypto op) will work using the same semantics as 
SOCK_DGRAM/SOCK_SEQPACKET. With those sockets, as much data as will fit is 
copied in to the read buffer and the remainder is discarded.

I realize there's a performance and memory tradeoff, since the crypto 
algorithm needs a sufficiently large output buffer that would have to be 
created by AF_ALG akcipher. The user could manage that tradeoff by 
providing a larger buffer (typically key_size?) if it wants to avoid 
allocating and copying intermediate buffers inside the kernel.

--
Mat Martineau
Intel OTC

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

Re: [PATCH v6 3/6] crypto: AF_ALG -- add asymmetric cipher  interface Mat Martineau <mathew.j.martineau@linux.intel.com> - 2016-06-23 01:10 +0200
  Re: [PATCH v6 3/6] crypto: AF_ALG -- add asymmetric cipher interface Stephan Mueller <smueller@chronox.de> - 2016-06-23 07:10 +0200
    Re: [PATCH v6 3/6] crypto: AF_ALG -- add asymmetric cipher interface Denis Kenzior <denkenz@gmail.com> - 2016-06-23 17:30 +0200

csiph-web