Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1428979

Re: [PATCHv2 1/7] ppc bpf/jit: Disable classic BPF JIT on ppc64le

From Thadeu Lima de Souza Cascardo <cascardo@redhat.com>
Newsgroups linux.kernel
Subject Re: [PATCHv2 1/7] ppc bpf/jit: Disable classic BPF JIT on ppc64le
Date 2016-06-22 19:00 +0200
Message-ID <rMTFo-5Zi-29@gated-at.bofh.it> (permalink)
References <rMTcl-5Ma-3@gated-at.bofh.it> <rMTcl-5Ma-1@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw


On Wed, Jun 22, 2016 at 09:55:01PM +0530, Naveen N. Rao wrote:
> Classic BPF JIT was never ported completely to work on little endian
> powerpc. However, it can be enabled and will crash the system when used.
> As such, disable use of BPF JIT on ppc64le.

Thanks, Naveen.

Acked-by: Thadeu Lima de Souza Cascardo <cascardo@redhat.com>

> 
> Cc: stable@vger.kernel.org
> Cc: Matt Evans <matt@ozlabs.org>
> Cc: Denis Kirjanov <kda@linux-powerpc.org>
> Cc: Michael Ellerman <mpe@ellerman.id.au>
> Cc: Paul Mackerras <paulus@samba.org>
> Cc: Alexei Starovoitov <ast@fb.com>
> Cc: Daniel Borkmann <daniel@iogearbox.net>
> Cc: "David S. Miller" <davem@davemloft.net>
> Cc: Ananth N Mavinakayanahalli <ananth@in.ibm.com>
> Cc: Thadeu Lima de Souza Cascardo <cascardo@redhat.com>
> Reported-by: Thadeu Lima de Souza Cascardo <cascardo@redhat.com>
> Signed-off-by: Naveen N. Rao <naveen.n.rao@linux.vnet.ibm.com>
> ---
>  arch/powerpc/Kconfig | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/arch/powerpc/Kconfig b/arch/powerpc/Kconfig
> index 01f7464..0a9d439 100644
> --- a/arch/powerpc/Kconfig
> +++ b/arch/powerpc/Kconfig
> @@ -128,7 +128,7 @@ config PPC
>  	select IRQ_FORCED_THREADING
>  	select HAVE_RCU_TABLE_FREE if SMP
>  	select HAVE_SYSCALL_TRACEPOINTS
> -	select HAVE_CBPF_JIT
> +	select HAVE_CBPF_JIT if CPU_BIG_ENDIAN
>  	select HAVE_ARCH_JUMP_LABEL
>  	select ARCH_HAVE_NMI_SAFE_CMPXCHG
>  	select ARCH_HAS_GCOV_PROFILE_ALL
> -- 
> 2.8.2
> 

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread


Thread

[PATCHv2 1/7] ppc bpf/jit: Disable classic BPF JIT on ppc64le "Naveen N. Rao" <naveen.n.rao@linux.vnet.ibm.com> - 2016-06-22 18:30 +0200
  Re: [PATCHv2 1/7] ppc bpf/jit: Disable classic BPF JIT on ppc64le Thadeu Lima de Souza Cascardo <cascardo@redhat.com> - 2016-06-22 19:00 +0200
  Re: [PATCHv2,1/7] ppc bpf/jit: Disable classic BPF JIT on ppc64le Michael Ellerman <mpe@ellerman.id.au> - 2016-06-23 11:30 +0200

csiph-web