Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1428184

Re: [PATCH v2] scripts/gdb: add constants.py to .gitignore

Show all headers | View raw

On 21/06/16 22:11, Omar Sandoval wrote:
> From: Omar Sandoval <osandov@fb.com>
> 
> Since scripts/gdb/linux/constants.py is autogenerated, this should have
> been added to .gitignore when it was introduced.
> 
> Fixes: f197d75fcad1 ("scripts/gdb: provide linux constants")
> Signed-off-by: Omar Sandoval <osandov@fb.com>
> ---
> Thanks, Kieran, I totally missed the comment in top-level .gitignore.
> 
>  scripts/gdb/linux/.gitignore | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/scripts/gdb/linux/.gitignore b/scripts/gdb/linux/.gitignore
> index 52e4e61140d1..d5abd6ce9425 100644
> --- a/scripts/gdb/linux/.gitignore
> +++ b/scripts/gdb/linux/.gitignore
> @@ -1,2 +1,3 @@
>  *.pyc
>  *.pyo
> +/constants.py

Does this work with '/' at the beginning of the line?
It looks like all the other sub-tree .gitignores don't use a leading /
on their ignores

If you're happy, I'd like to drop the leading '/'.

(I think I can do this silently as I pick the patch if you approve,
rather than send another patch for a one-byte change)

Other than that:

Signed-off-by: Kieran Bingham <kieran@bingham.xyz>
-- 
Regards

Kieran Bingham

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

Re: [PATCH v2] scripts/gdb: add constants.py to .gitignore Kieran Bingham <kieran@ksquared.org.uk> - 2016-06-21 23:30 +0200
  Re: [PATCH v2] scripts/gdb: add constants.py to .gitignore Omar Sandoval <osandov@osandov.com> - 2016-06-21 23:40 +0200
    Re: [PATCH v2] scripts/gdb: add constants.py to .gitignore Kieran Bingham <kieran@ksquared.org.uk> - 2016-06-22 00:10 +0200
      Re: [PATCH v2] scripts/gdb: add constants.py to .gitignore Omar Sandoval <osandov@osandov.com> - 2016-06-22 00:10 +0200

csiph-web