Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1423325
| From | Andy Lutomirski <luto@amacapital.net> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [x86] 5ac0c41bf3: WARNING: CPU: 0 PID: 0 at arch/x86/mm/extable.c:50 ex_handler_rdmsr_unsafe |
| Date | 2016-06-15 20:50 +0200 |
| Message-ID | <rKo30-69o-23@gated-at.bofh.it> (permalink) |
| References | (3 earlier) <rKngC-5DP-7@gated-at.bofh.it> <rKngC-5DP-5@gated-at.bofh.it> <rKnqi-5W3-19@gated-at.bofh.it> <rKnzY-5Zq-43@gated-at.bofh.it> <rKnJD-62T-9@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
On Wed, Jun 15, 2016 at 11:23 AM, Borislav Petkov <bp@alien8.de> wrote:
> On Wed, Jun 15, 2016 at 11:12:37AM -0700, Andy Lutomirski wrote:
>> I want to see actual_problem in the log.
>
> So the optimal thing to do for that is to return an error to the calling
> site which says "exception got handled" and then the *calling* site can
> dump_stack().
>
> And the old code did that:
>
> static inline unsigned long long native_read_msr_safe(unsigned int msr,
> int *err)
> {
> DECLARE_ARGS(val, low, high);
>
> asm volatile("2: rdmsr ; xor %[err],%[err]\n"
> "1:\n\t"
> ".section .fixup,\"ax\"\n\t"
> "3: mov %[fault],%[err] ; jmp 1b\n\t"
> ".previous\n\t"
> _ASM_EXTABLE(2b, 3b)
> : [err] "=r" (*err), EAX_EDX_RET(val, low, high)
> : "c" (msr), [fault] "i" (-EIO));
> ^^^^
>
Then we end up with bloat. The current thing generates very compact code.
--Andy
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
Re: [x86] 5ac0c41bf3: WARNING: CPU: 0 PID: 0 at arch/x86/mm/extable.c:50 ex_handler_rdmsr_unsafe Borislav Petkov <bp@alien8.de> - 2016-06-15 16:30 +0200
Re: [x86] 5ac0c41bf3: WARNING: CPU: 0 PID: 0 at arch/x86/mm/extable.c:50 ex_handler_rdmsr_unsafe Paolo Bonzini <pbonzini@redhat.com> - 2016-06-15 17:00 +0200
Re: [x86] 5ac0c41bf3: WARNING: CPU: 0 PID: 0 at arch/x86/mm/extable.c:50 ex_handler_rdmsr_unsafe Eduardo Habkost <ehabkost@redhat.com> - 2016-06-15 17:00 +0200
Re: [x86] 5ac0c41bf3: WARNING: CPU: 0 PID: 0 at arch/x86/mm/extable.c:50 ex_handler_rdmsr_unsafe Borislav Petkov <bp@alien8.de> - 2016-06-15 19:10 +0200
Re: [x86] 5ac0c41bf3: WARNING: CPU: 0 PID: 0 at arch/x86/mm/extable.c:50 ex_handler_rdmsr_unsafe Andy Lutomirski <luto@amacapital.net> - 2016-06-15 19:40 +0200
Re: [x86] 5ac0c41bf3: WARNING: CPU: 0 PID: 0 at arch/x86/mm/extable.c:50 ex_handler_rdmsr_unsafe Andy Lutomirski <luto@amacapital.net> - 2016-06-15 20:00 +0200
Re: [x86] 5ac0c41bf3: WARNING: CPU: 0 PID: 0 at arch/x86/mm/extable.c:50 ex_handler_rdmsr_unsafe Borislav Petkov <bp@alien8.de> - 2016-06-15 20:10 +0200
Re: [x86] 5ac0c41bf3: WARNING: CPU: 0 PID: 0 at arch/x86/mm/extable.c:50 ex_handler_rdmsr_unsafe Andy Lutomirski <luto@amacapital.net> - 2016-06-15 20:20 +0200
Re: [x86] 5ac0c41bf3: WARNING: CPU: 0 PID: 0 at arch/x86/mm/extable.c:50 ex_handler_rdmsr_unsafe Borislav Petkov <bp@alien8.de> - 2016-06-15 20:30 +0200
Re: [x86] 5ac0c41bf3: WARNING: CPU: 0 PID: 0 at arch/x86/mm/extable.c:50 ex_handler_rdmsr_unsafe Andy Lutomirski <luto@amacapital.net> - 2016-06-15 20:50 +0200
Re: [x86] 5ac0c41bf3: WARNING: CPU: 0 PID: 0 at arch/x86/mm/extable.c:50 ex_handler_rdmsr_unsafe Borislav Petkov <bp@alien8.de> - 2016-06-15 20:00 +0200
csiph-web