Re: [PATCH v3] sched: fix first task of a task group is attached twice

From	Vincent Guittot <vincent.guittot@linaro.org>
Newsgroups	linux.kernel
Subject	Re: [PATCH v3] sched: fix first task of a task group is attached twice
Date	2016-06-16 11:50 +0200
Message-ID	<rKC5X-6GJ-5@gated-at.bofh.it> (permalink)
References	<rEpuP-YG-45@gated-at.bofh.it> <rExLI-6b9-9@gated-at.bofh.it> <rKw0x-2Xj-1@gated-at.bofh.it> <rKzKO-5hx-33@gated-at.bofh.it> <rKzUu-5kS-19@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On 16 June 2016 at 01:24, Yuyang Du <yuyang.du@intel.com> wrote:
> On Thu, Jun 16, 2016 at 09:12:58AM +0200, Vincent Guittot wrote:
>> > Then, when enqueued, both cfs_rq and task will be decayed to 0, due to
>> > a large gap between 1 and now, no?
>>
>> yes, like it is done currently (but 1ns later) .
>
> Well, currently, cfs_rq will be decayed to 0, but will then add the task.
> So it turns out the current result is right. Attached twice, but result
> is right. Correct?

So the load looks accidentally correct but not the utilization which
will be overestimated up to twice the max

With this change,the behavior of the 1st task becomes the same as what
happen to the other tasks that will be attached to the task group that
has been idle for a while and  that has an old last_update_time.
Then, i have other pending patch to fix this behavior, has mentioned
in a previous email

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

Re: [PATCH v3] sched: fix first task of a task group is attached  twice Yuyang Du <yuyang.du@intel.com> - 2016-06-16 05:20 +0200
  Re: [PATCH v3] sched: fix first task of a task group is attached twice Vincent Guittot <vincent.guittot@linaro.org> - 2016-06-16 09:20 +0200
    Re: [PATCH v3] sched: fix first task of a task group is attached  twice Yuyang Du <yuyang.du@intel.com> - 2016-06-16 09:30 +0200
      Re: [PATCH v3] sched: fix first task of a task group is attached twice Vincent Guittot <vincent.guittot@linaro.org> - 2016-06-16 11:50 +0200

csiph-web