Re: [PATCH] gcc-plugins: disable under COMPILE_TEST

From	Kees Cook <keescook@chromium.org>
Newsgroups	linux.kernel
Subject	Re: [PATCH] gcc-plugins: disable under COMPILE_TEST
Date	2016-06-13 22:20 +0200
Message-ID	<rJGuZ-2JJ-9@gated-at.bofh.it> (permalink)
References	(1 earlier) <rITXj-5lG-1@gated-at.bofh.it> <rJlJT-5Ww-1@gated-at.bofh.it> <rJm3f-66u-7@gated-at.bofh.it> <rJnLH-7eJ-5@gated-at.bofh.it> <rJEWe-1BQ-21@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Mon, Jun 13, 2016 at 11:32 AM, Austin S. Hemmelgarn
<ahferroin7@gmail.com> wrote:
> On 2016-06-12 20:18, Emese Revfy wrote:
>>
>> On Sun, 12 Jun 2016 15:25:39 -0700
>> Kees Cook <keescook@chromium.org> wrote:
>>
>>> I don't like this because it means if someone specifically selects
>>> some plugins in their .config, and the headers are missing, the kernel
>>> will successfully compile. For many plugins, this results in a kernel
>>> that lacks the requested security features, and that I really do not
>>> want to have happening. I'm okay leaving these disabled for compile
>>> tests for now. We can revisit this once more distros have plugins
>>> enabled by default.
>>
>>
>> You are right. Your patch is safer.
>>
> Why not make it so that if COMPILE_TEST is enabled, the build warns if it
> can't find the headers, otherwise it fails?  That way, people who are doing
> all*config builds but don't have the headers will still get some build
> coverage, and the people who are enabling it as a security feature will
> still get build failures.

I don't see a clear way to do this, but if you can find a way to make
that happen, please send a patch! :)

-Kees

-- 
Kees Cook
Chrome OS & Brillo Security

Thread

[PATCH] gcc-plugins: disable under COMPILE_TEST Kees Cook <keescook@chromium.org> - 2016-06-11 18:20 +0200
  Re: [PATCH] gcc-plugins: disable under COMPILE_TEST Paul Gortmaker <paul.gortmaker@windriver.com> - 2016-06-11 18:30 +0200
    Re: [PATCH] gcc-plugins: disable under COMPILE_TEST Emese Revfy <re.emese@gmail.com> - 2016-06-13 00:10 +0200
      Re: [PATCH] gcc-plugins: disable under COMPILE_TEST Kees Cook <keescook@chromium.org> - 2016-06-13 00:30 +0200
        Re: [PATCH] gcc-plugins: disable under COMPILE_TEST Emese Revfy <re.emese@gmail.com> - 2016-06-13 02:20 +0200
          Re: [PATCH] gcc-plugins: disable under COMPILE_TEST "Austin S. Hemmelgarn" <ahferroin7@gmail.com> - 2016-06-13 20:40 +0200
            Re: [PATCH] gcc-plugins: disable under COMPILE_TEST Kees Cook <keescook@chromium.org> - 2016-06-13 22:20 +0200
              Re: [PATCH] gcc-plugins: disable under COMPILE_TEST Michael Ellerman <mpe@ellerman.id.au> - 2016-06-14 04:10 +0200
  Re: [PATCH] gcc-plugins: disable under COMPILE_TEST Sudip Mukherjee <sudipm.mukherjee@gmail.com> - 2016-06-13 10:00 +0200
  Re: [PATCH] gcc-plugins: disable under COMPILE_TEST Sedat Dilek <sedat.dilek@gmail.com> - 2016-06-13 10:50 +0200
    Re: [PATCH] gcc-plugins: disable under COMPILE_TEST Kees Cook <keescook@chromium.org> - 2016-06-13 22:20 +0200

csiph-web