Groups > linux.kernel > #1419278

[PATCH V2 08/11] net: mediatek: increase watchdog_timeo

From	John Crispin <john@phrozen.org>
Newsgroups	linux.kernel
Subject	[PATCH V2 08/11] net: mediatek: increase watchdog_timeo
Date	2016-06-10 13:30 +0200
Message-ID	<rIsNs-3Vg-21@gated-at.bofh.it> (permalink)
References	<rIsNs-3Vg-5@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

During stress testing, after reducing the threshold value, we have seen
TX timeouts that were caused by the watchdog_timeo value being too low.
Increase the value to 5 * HZ which is a value commonly used by many other
drivers.

Signed-off-by: John Crispin <john@phrozen.org>
---
 drivers/net/ethernet/mediatek/mtk_eth_soc.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/net/ethernet/mediatek/mtk_eth_soc.c b/drivers/net/ethernet/mediatek/mtk_eth_soc.c
index 8b289e1..24714ab 100644
--- a/drivers/net/ethernet/mediatek/mtk_eth_soc.c
+++ b/drivers/net/ethernet/mediatek/mtk_eth_soc.c
@@ -1688,7 +1688,7 @@ static int mtk_add_mac(struct mtk_eth *eth, struct device_node *np)
 	mac->hw_stats->reg_offset = id * MTK_STAT_OFFSET;
 
 	SET_NETDEV_DEV(eth->netdev[id], eth->dev);
-	eth->netdev[id]->watchdog_timeo = HZ;
+	eth->netdev[id]->watchdog_timeo = 5 * HZ;
 	eth->netdev[id]->netdev_ops = &mtk_netdev_ops;
 	eth->netdev[id]->base_addr = (unsigned long)eth->base;
 	eth->netdev[id]->vlan_features = MTK_HW_FEATURES &
-- 
1.7.10.4

Back to linux.kernel | Previous | Next | Find similar | Unroll thread

Thread

[PATCH V2 08/11] net: mediatek: increase watchdog_timeo John Crispin <john@phrozen.org> - 2016-06-10 13:30 +0200

csiph-web