Re: [PATCH 06/21] fs: udf: Replace CURRENT_TIME with current_fs_time()

From	Deepa Dinamani <deepa.kernel@gmail.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH 06/21] fs: udf: Replace CURRENT_TIME with current_fs_time()
Date	2016-06-10 03:00 +0200
Message-ID	<rIiXM-5N6-7@gated-at.bofh.it> (permalink)
References	<rI0o9-1PH-9@gated-at.bofh.it> <rI0xQ-1Vf-13@gated-at.bofh.it> <rI2SZ-3kN-31@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Thu, Jun 9, 2016 at 12:41 AM, Jan Kara <jack@suse.cz> wrote:
> On Wed 08-06-16 22:04:50, Deepa Dinamani wrote:
>> Logical Volume Integrity format is described to have the
>> same timestamp format for "Recording Date and time" as
>> the other [a,c,m]timestamps.
>> Hence using current_fs_time() instead here promises to
>> maintain the same granularity as other timestamps.
>>
> Just one nit below.
>
>> @@ -2030,7 +2030,7 @@ static void udf_close_lvid(struct super_block *sb)
>> -     udf_time_to_disk_stamp(&lvid->recordingDateAndTime, CURRENT_TIME);
>> +     udf_time_to_disk_stamp(&lvid->recordingDateAndTime, current_fs_time(sb));
>
> Please wrap this line properly so that it does not exceed 80 characters.
> Other than that feel free to add:
>
> Reviewed-by: Jan Kara <jack@suse.cz>

Thanks, I will take care of this in v2 of the patch series.
- Deepa

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH 06/21] fs: udf: Replace CURRENT_TIME with current_fs_time() Deepa Dinamani <deepa.kernel@gmail.com> - 2016-06-09 07:20 +0200
  Re: [PATCH 06/21] fs: udf: Replace CURRENT_TIME with  current_fs_time() Jan Kara <jack@suse.cz> - 2016-06-09 09:50 +0200
    Re: [PATCH 06/21] fs: udf: Replace CURRENT_TIME with current_fs_time() Deepa Dinamani <deepa.kernel@gmail.com> - 2016-06-10 03:00 +0200

csiph-web