Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1419813

Re: [Y2038] [PATCH 02/21] fs: ext4: Use current_fs_time() for inode timestamps

Show all headers | View raw

On Thursday, June 9, 2016 11:45:01 AM CEST Linus Torvalds wrote:
> On Wed, Jun 8, 2016 at 10:04 PM, Deepa Dinamani <deepa.kernel@gmail.com> wrote:
> > CURRENT_TIME_SEC and CURRENT_TIME are not y2038 safe.
> > current_fs_time() will be transitioned to be y2038 safe
> > along with vfs.
> >
> > current_fs_time() returns timestamps according to the
> > granularities set in the super_block.
> 
> All existing users and all the ones in this patch (and the others too,
> although I didn't go through them very carefully) really would prefer
> just passing in the inode directly, rather than the superblock.
> 
> So I don't want to add more users of this broken interface.  It was a
> mistake to use the superblock. The fact that the time granularity
> exists there is pretty much irrelevant. If every single user wants to
> use an inode pointer, then that is what the function should get.

I guess it would help to give the function a new name in the process,
if only to avoid possible conflicts. That new name of course needs to
be at least as intuitive as the old one. How about

struct timespec fs_timestamp(struct inode *);

? 

	Arnd

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH 00/21] Delete CURRENT_TIME and CURRENT_TIME_SEC macros Deepa Dinamani <deepa.kernel@gmail.com> - 2016-06-09 07:20 +0200
  [PATCH 18/21] fs: nfs: Make nfs boot time y2038 safe Deepa Dinamani <deepa.kernel@gmail.com> - 2016-06-09 07:20 +0200
    Re: [PATCH 18/21] fs: nfs: Make nfs boot time y2038 safe Trond Myklebust <trondmy@primarydata.com> - 2016-06-09 21:30 +0200
      Re: [PATCH 18/21] fs: nfs: Make nfs boot time y2038 safe Deepa Dinamani <deepa.kernel@gmail.com> - 2016-06-09 23:20 +0200
        Re: [PATCH 18/21] fs: nfs: Make nfs boot time y2038 safe Anna Schumaker <Anna.Schumaker@netapp.com> - 2016-06-10 15:20 +0200
          Re: [PATCH 18/21] fs: nfs: Make nfs boot time y2038 safe Trond Myklebust <trondmy@primarydata.com> - 2016-06-10 16:10 +0200
  [PATCH 02/21] fs: ext4: Use current_fs_time() for inode timestamps Deepa Dinamani <deepa.kernel@gmail.com> - 2016-06-09 07:20 +0200
    Re: [PATCH 02/21] fs: ext4: Use current_fs_time() for inode timestamps Linus Torvalds <torvalds@linux-foundation.org> - 2016-06-09 20:50 +0200
      Re: [PATCH 02/21] fs: ext4: Use current_fs_time() for inode timestamps Linus Torvalds <torvalds@linux-foundation.org> - 2016-06-09 21:00 +0200
      Re: [Y2038] [PATCH 02/21] fs: ext4: Use current_fs_time() for inode timestamps Arnd Bergmann <arnd@arndb.de> - 2016-06-11 00:20 +0200
        Re: [Y2038] [PATCH 02/21] fs: ext4: Use current_fs_time() for inode timestamps Deepa Dinamani <deepa.kernel@gmail.com> - 2016-06-14 20:00 +0200
          Re: [Y2038] [PATCH 02/21] fs: ext4: Use current_fs_time() for inode timestamps Arnd Bergmann <arnd@arndb.de> - 2016-06-14 23:00 +0200
  [PATCH 07/21] fs: cifs: Replace CURRENT_TIME by current_fs_time() Deepa Dinamani <deepa.kernel@gmail.com> - 2016-06-09 07:20 +0200
  Re: [PATCH 01/21] fs: Replace CURRENT_TIME_SEC with current_fs_time() Jan Kara <jack@suse.cz> - 2016-06-09 09:40 +0200
    Re: [PATCH 01/21] fs: Replace CURRENT_TIME_SEC with current_fs_time() Linus Torvalds <torvalds@linux-foundation.org> - 2016-06-09 21:20 +0200
      Re: [PATCH 01/21] fs: Replace CURRENT_TIME_SEC with current_fs_time() Deepa Dinamani <deepa.kernel@gmail.com> - 2016-06-09 22:50 +0200
  Re: [PATCH 00/21] Delete CURRENT_TIME and CURRENT_TIME_SEC macros Felipe Balbi <balbi@kernel.org> - 2016-06-09 10:00 +0200
  Re: [PATCH 01/21] fs: Replace CURRENT_TIME_SEC with current_fs_time() Bob Copeland <me@bobcopeland.com> - 2016-06-09 14:40 +0200
  Re: [PATCH 01/21] fs: Replace CURRENT_TIME_SEC with current_fs_time() Arnd Bergmann <arnd@arndb.de> - 2016-06-11 00:30 +0200
    Re: [PATCH 01/21] fs: Replace CURRENT_TIME_SEC with current_fs_time() Deepa Dinamani <deepa.kernel@gmail.com> - 2016-06-11 07:10 +0200
      Re: [PATCH 01/21] fs: Replace CURRENT_TIME_SEC with current_fs_time() Arnd Bergmann <arnd@arndb.de> - 2016-06-11 23:10 +0200

csiph-web