Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1418241
| From | Lee Jones <lee.jones@linaro.org> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [RESEND PATCH v5 1/5] mfd: RK808: Add RK818 support |
| Date | 2016-06-09 13:20 +0200 |
| Message-ID | <rI6ad-5BC-1@gated-at.bofh.it> (permalink) |
| References | <rFuLL-2xr-7@gated-at.bofh.it> <rHMuT-1eQ-39@gated-at.bofh.it> <rI3vH-3P1-3@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
On Thu, 09 Jun 2016, Wadim Egorov wrote:
> On 08.06.2016 16:17, Lee Jones wrote:
> > On Thu, 02 Jun 2016, Wadim Egorov wrote:
> >
> >> The RK818 chip is a power management IC for multimedia and handheld
> > "Power Management IC (PMIC)"
> >
> >> devices. It contains the following components:
> >>
> >> - Regulators
> >> - RTC
> >> - Clkout
> > Clocking
> >
> >> - battery support
> > Battery support
> >
> >> Both chips RK808 and RK818 are using a similar register map.
> > "Both RK808 ad RK818 chips"
> >
> >> So we can reuse the RTC and Clkout functionality.
> > Swap '.' for ','.
> >
> >> Signed-off-by: Wadim Egorov <w.egorov@phytec.de>
> >> ---
> >> drivers/mfd/Kconfig | 4 +-
> >> drivers/mfd/rk808.c | 231 ++++++++++++++++++++++++++++++++++++++--------
> >> include/linux/mfd/rk808.h | 162 ++++++++++++++++++++++++++++++--
> >> 3 files changed, 350 insertions(+), 47 deletions(-)
[...]
> >> -struct rk808_reg_data {
> >> - int addr;
> >> - int mask;
> >> - int value;
> >> -};
> > Why are you moving this to the header?
>
> It is now part of the rk808 struct.
Why?
--
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
[RESEND PATCH v5 1/5] mfd: RK808: Add RK818 support Wadim Egorov <w.egorov@phytec.de> - 2016-06-02 09:00 +0200
[RESEND PATCH v5 5/5] rtc: Kconfig: Name RK818 in Kconfig for RTC_DRV_RK808 Wadim Egorov <w.egorov@phytec.de> - 2016-06-02 09:00 +0200
Re: [RESEND PATCH v5 1/5] mfd: RK808: Add RK818 support Lee Jones <lee.jones@linaro.org> - 2016-06-08 16:20 +0200
Re: [RESEND PATCH v5 1/5] mfd: RK808: Add RK818 support Wadim Egorov <w.egorov@phytec.de> - 2016-06-09 10:30 +0200
Re: [RESEND PATCH v5 1/5] mfd: RK808: Add RK818 support Lee Jones <lee.jones@linaro.org> - 2016-06-09 13:20 +0200
Re: [RESEND PATCH v5 1/5] mfd: RK808: Add RK818 support Wadim Egorov <w.egorov@phytec.de> - 2016-06-09 15:20 +0200
Re: [RESEND PATCH v5 1/5] mfd: RK808: Add RK818 support Lee Jones <lee.jones@linaro.org> - 2016-06-09 17:30 +0200
csiph-web