Re: [PATCH v2 0/4] dell-wmi: Changes in WMI event code handling

From	Michał Kępień <kernel@kempniu.pl>
Newsgroups	linux.kernel
Subject	Re: [PATCH v2 0/4] dell-wmi: Changes in WMI event code handling
Date	2016-06-09 14:00 +0200
Message-ID	<rI6MW-5RF-37@gated-at.bofh.it> (permalink)
References	<rHyLf-GT-13@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

> First patch describe problem about 0xe045 code. Second and third are just
> cosmetic and last rework code which processing WMI events. It should be
> properly tested on more Dell machines, to check that everything is still
> working correctly.
> 
> Changes since v1:
> * Fixed comments
> * Fixed memory leak
> * Added Tested-By lines
> * Added event 0xe06e

Pali, assuming that you will address Darren's concerns (empty commit
message for patch 2/4, switch fall-through in patch 4/4 and some
comments over 80 characters in patches 2/4 and 4/4), feel free to add:

Reviewed-by: Michał Kępień <kernel@kempniu.pl>

as I don't see any further issues with this series.

-- 
Best regards,
Michał Kępień

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH v2 0/4] dell-wmi: Changes in WMI event code handling Pali Rohár <pali.rohar@gmail.com> - 2016-06-08 01:40 +0200
  [PATCH v2 2/4] dell-wmi: Sort WMI event codes and update comments Pali Rohár <pali.rohar@gmail.com> - 2016-06-08 01:40 +0200
  [PATCH v2 3/4] dell-wmi: Add information about other WMI event codes Pali Rohár <pali.rohar@gmail.com> - 2016-06-08 01:40 +0200
  [PATCH v2 4/4] dell-wmi: Rework code for generating sparse keymap and processing WMI events Pali Rohár <pali.rohar@gmail.com> - 2016-06-08 01:40 +0200
    Re: [PATCH v2 4/4] dell-wmi: Rework code for generating sparse  keymap and processing WMI events Darren Hart <dvhart@infradead.org> - 2016-06-09 01:00 +0200
      Re: [PATCH v2 4/4] dell-wmi: Rework code for generating sparse  keymap and processing WMI events Michał Kępień <kernel@kempniu.pl> - 2016-06-09 13:30 +0200
        Re: [PATCH v2 4/4] dell-wmi: Rework code for generating sparse keymap and processing WMI events Pali Rohár <pali.rohar@gmail.com> - 2016-06-09 13:40 +0200
          Re: [PATCH v2 4/4] dell-wmi: Rework code for generating sparse  keymap and processing WMI events Darren Hart <dvhart@infradead.org> - 2016-06-09 22:00 +0200
  [PATCH v2 1/4] dell-wmi: Ignore WMI event code 0xe045 Pali Rohár <pali.rohar@gmail.com> - 2016-06-08 01:40 +0200
  Re: [PATCH v2 0/4] dell-wmi: Changes in WMI event code handling Michał Kępień <kernel@kempniu.pl> - 2016-06-09 14:00 +0200

csiph-web