Re: [PATCH v5 01/18] remoteproc: make rsc table support optional

From	Bjorn Andersson <bjorn.andersson@linaro.org>
Newsgroups	linux.kernel
Subject	Re: [PATCH v5 01/18] remoteproc: make rsc table support optional
Date	2016-06-07 22:00 +0200
Message-ID	<rHvkl-6Ti-9@gated-at.bofh.it> (permalink)
References	<rHrTr-4UH-19@gated-at.bofh.it> <rHrTr-4UH-17@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Tue 07 Jun 09:18 PDT 2016, Peter Griffin wrote:

> Some firmware and rproc drivers such as slim core don't have a
> resource table. To avoid having to fudge an empty table
> in the rproc driver this patch introduces a new has_rsctable
> flag. rproc drivers which don't require a rsc table can set
> this flag to false, and it avoids doing the initial async
> firmware load in rproc_add_virtio_devices() to parse the
> rsc table during rproc_add(), and also optimises rproc_fw_boot()
> code path to avoid unnecessary rsc table processing of an
> empty table.
> 
> Signed-off-by: Peter Griffin <peter.griffin@linaro.org>

Hi Peter,

Thanks for the patch. I do however dislike the amount of conditionals
already in these code paths, so I'm not in favour of adding more.

Please revert back to providing a dummy table from your driver and let's
handle this topic separate of this series.

Regards,
Bjorn

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH v5 01/18] remoteproc: make rsc table support optional Peter Griffin <peter.griffin@linaro.org> - 2016-06-07 18:20 +0200
  Re: [PATCH v5 01/18] remoteproc: make rsc table support optional Bjorn Andersson <bjorn.andersson@linaro.org> - 2016-06-07 22:00 +0200

csiph-web